chore(RHTAPWATCH-741): Add recording rules for exporter #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
hmariset
force-pushed
the
recording-rules-exporter
branch
from
07c9400
to
9c20dbc
Compare
hmariset
force-pushed
the
recording-rules-exporter
branch
from
9c20dbc
to
ff5c94d
Compare
|
/retest |
hmariset
force-pushed
the
recording-rules-exporter
branch
9 times, most recently
from
f7bb121
to
bd6fb50
Compare
yftacherzog
reviewed
Feb 18, 2024
yftacherzog
requested changes
Feb 18, 2024
There was a problem hiding this comment.
- We need test cases for the recording rules. You can find references for recording rules test cases in our git history (we used to have a couple of recording rules in the past and you should be able to see references to their test cases).
- I'm concerned for the fact that the metric name can change without us having to change the test cases (we might be missing test cases). Not sure if this PR is the place to address that, but please spend some time examining this and open a ticket to address/explore it.
hmariset
force-pushed
the
recording-rules-exporter
branch
2 times, most recently
from
a50c91d
to
c95471e
Compare
Added the recording rules test case. I'll open a new ticket for exploring the second question. |
hmariset
force-pushed
the
recording-rules-exporter
branch
from
c95471e
to
ad6c682
Compare
yftacherzog
reviewed
Feb 20, 2024
yftacherzog
reviewed
Feb 20, 2024
Add recording rules to translate the components existing metrics to expose availability. Signed-off-by: Homaja Marisetty <[email protected]>
hmariset
force-pushed
the
recording-rules-exporter
branch
from
ad6c682
to
fcdd58d
Compare
|
@yftacherzog @amisstea I have updated the code. Please review again. |
amisstea
approved these changes
Feb 20, 2024
|
/retest |
yftacherzog
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Looks good!
Once you have this one merged, make sure you create the necessary changes in app-interface and update the readme here with the instructions for how to update the recording rules references.
Sure Yftach! I already created the MR for app-interface (https://gitlab.cee.redhat.com/service/app-interface/-/merge_requests/97295) and will update README as well. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add recording rules to translate the components existing metrics to expose availability.