chore(RHTAPWATCH-741): Add recording rules for exporter

Add recording rules to translate the components existing metrics to expose availability. Signed-off-by: Homaja Marisetty <[email protected]>
redhat-appstudio · Feb 19, 2024 · a50c91d · a50c91d
1 parent 503921a
commit a50c91d
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 5 deletions.
diff --git a/.tekton/o11y-pull-request.yaml b/.tekton/o11y-pull-request.yaml
@@ -280,7 +280,7 @@ spec:
  - name: url
  value: https://github.com/tektoncd/catalog.git
  - name: revision
- value: main
+ value: f4708d478ee8fac6b5b68347cde087cb7c1d1b1c
  - name: pathInRepo
  value: task/kube-linter/0.1/kube-linter.yaml
  params:

diff --git a/exporters/dsexporter/dsexporter.go b/exporters/dsexporter/dsexporter.go
@@ -14,7 +14,6 @@ import (
  "sigs.k8s.io/controller-runtime/pkg/client/config"
 )
 
-const service = "grafana"
 const check = "prometheus-appstudio-ds"
 var allDataSources = GetDataSources
 
@@ -26,10 +25,10 @@ type CustomCollector struct {
 func NewCustomCollector() *CustomCollector {
  return &CustomCollector{
  konfluxUp: prometheus.NewGaugeVec(prometheus.GaugeOpts{
- Name: "konflux_up",
+ Name: "grafana_ds_up",
  Help: "Availability of the Konflux default grafana datasource",
  },
- []string{"service", "check"}),
+ []string{"check"}),
  }
 }
 
@@ -53,7 +52,7 @@ func (e *CustomCollector) Collect(ch chan<- prometheus.Metric) {
  }
  }
 
- e.konfluxUp.WithLabelValues(service, check).Set(availability)
+ e.konfluxUp.WithLabelValues(check).Set(availability)
  e.konfluxUp.Collect(ch)
 }
 

diff --git a/rhobs/recording/exporter_recording_rules.yml b/rhobs/recording/exporter_recording_rules.yml
@@ -0,0 +1,5 @@
+groups:
+- name: exporter
+ rules:
+ - record: konflux_up
+ expr: label_replace(grafana_ds_up, "service", "grafana", "__name__", "(.+)")
diff --git a/test/promql/tests/recording/exporter_recording_rules_test.yml b/test/promql/tests/recording/exporter_recording_rules_test.yml
@@ -0,0 +1,25 @@
+evaluation_interval: 1m
+
+rule_files:
+- ../../../../rhobs/recording/exporter_recording_rules.yml
+
+tests:
+- interval: 1m
+ name: DSExporterTest
+ input_series:
+ - series: "grafana_ds_up{check='appstudio-ds'}"
+ values: "1 1 1 1 1"
+ - series: "grafana_ds_up{check='github'}"
+ values: "0 0 0 0 0"
+ - series: "grafana_ds_up{other_label='sso'}"
+ values: "0 1 0 1 0"
+ promql_expr_test:
+ - expr: konflux_up
+ eval_time: 5m
+ exp_samples:
+ - labels: konflux_up{service='grafana', check='appstudio-ds'}
+ value: 1
+ - labels: konflux_up{service='grafana', check='github'}
+ value: 0
+ - labels: konflux_up{service='grafana', other_label='sso'}
+ value: 0