Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(RHTAPWATCH-568): Add authentication to Service and ServiceMonitor #172

Merged
merged 1 commit into from
Feb 29, 2024
Merged

chore(RHTAPWATCH-568): Add authentication to Service and ServiceMonitor #172

merged 1 commit into from
Feb 29, 2024

Conversation

Kousalya1998
Copy link
Contributor

  • Add authentication to Service and ServiceMonitor

@Kousalya1998
Copy link
Contributor Author

@hmariset @yftacherzog @avi-biton PTAL at this PR.

@yftacherzog
Copy link
Member

@hmariset @yftacherzog @avi-biton PTAL at this PR.

Did you confirm it to be working as before @Kousalya1998

@hmariset hmariset mentioned this pull request Jan 22, 2024
Closed
@Kousalya1998 Kousalya1998 force-pushed the RHTAPWATCH-568 branch 3 times, most recently from 254349d to 01f7917 Compare January 24, 2024 10:28
@avi-biton
Copy link
Collaborator

@Kousalya1998 were you able to check this configuration?

@Kousalya1998 Kousalya1998 force-pushed the RHTAPWATCH-568 branch 3 times, most recently from 6b6d5d3 to caf3013 Compare January 24, 2024 12:55
yftacherzog
yftacherzog requested changes Jan 25, 2024
View reviewed changes
Copy link
Member

@yftacherzog yftacherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some pieces missing to make it work. See my comments here: https://redhat-internal.slack.com/archives/C04FDFTF8EB/p1706166238412489?thread_ts=1706163051.438089&cid=C04FDFTF8EB

@Kousalya1998 Kousalya1998 force-pushed the RHTAPWATCH-568 branch 8 times, most recently from cc72cbe to 45217bf Compare January 29, 2024 15:28
@Kousalya1998 Kousalya1998 force-pushed the RHTAPWATCH-568 branch 2 times, most recently from a4efa7f to b468dea Compare February 27, 2024 17:20
yftacherzog
yftacherzog reviewed Feb 28, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
yftacherzog
yftacherzog reviewed Feb 28, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@Kousalya1998 Kousalya1998 force-pushed the RHTAPWATCH-568 branch 4 times, most recently from f84ec63 to e0e429e Compare February 28, 2024 12:22
yftacherzog
yftacherzog reviewed Feb 28, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
hmariset
hmariset reviewed Feb 28, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
hmariset
hmariset approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@hmariset hmariset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the code and the target is up now.

yftacherzog
yftacherzog requested changes Feb 29, 2024
View reviewed changes
Copy link
Member

@yftacherzog yftacherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment from yesterday

@yftacherzog
Copy link
Member

Please confirm that you're able to deploy it with infra-deployment's preview script and it works as expected.

@Kousalya1998
Copy link
Contributor Author

Please confirm that you're able to deploy it with infra-deployment's preview script and it works as expected.

@yftacherzog Just deployed it with the infra-deployments preview script and it works as expected

yftacherzog
yftacherzog approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@yftacherzog yftacherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

avi-biton
avi-biton approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@avi-biton avi-biton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hmariset hmariset merged commit 95fbfc5 into redhat-appstudio:main Feb 29, 2024
2 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yftacherzog yftacherzog yftacherzog approved these changes

@amisstea amisstea amisstea approved these changes

@avi-biton avi-biton avi-biton approved these changes

@hmariset hmariset hmariset approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kousalya1998 @yftacherzog @avi-biton @amisstea @hmariset @klakshma21