Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(RHTAPWATCH-568): Add authentication to Service and ServiceMonitor #3110

Closed
wants to merge 1 commit into from
Closed

chore(RHTAPWATCH-568): Add authentication to Service and ServiceMonitor #3110

wants to merge 1 commit into from

Conversation

Kousalya1998
Copy link
Contributor

  • Update commit SHA

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 22, 2024

Hi @Kousalya1998. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amisstea
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 22, 2024
@hmariset
Copy link
Contributor

This change depends on the PR. Since the other PR is not merged yet and there might be some changes, will keep this on hold.

@openshift-ci openshift-ci bot removed the lgtm label Jan 22, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 22, 2024

New changes are detected. LGTM label has been removed.

@Kousalya1998 Kousalya1998 force-pushed the RHTAPWATCH-568 branch 11 times, most recently from fd9a756 to 810bfaf Compare January 30, 2024 16:34
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kousalya1998
Once this PR has been reviewed and has the lgtm label, please ask for approval from amisstea. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kousalya1998 Kousalya1998 force-pushed the RHTAPWATCH-568 branch 5 times, most recently from b0f344f to b0e2c15 Compare March 5, 2024 15:07
@rh-tap-build-team @klakshma21
pipeline-service update (redhat-appstudio#3277)
34f9eca 
* update components/monitoring/grafana/base/dashboards/pipeline-service/kustomization.yaml

* update components/pipeline-service/development/kustomization.yaml

* update components/pipeline-service/staging/base/kustomization.yaml

* update components/pipeline-service/staging/stone-stage-p01/deploy.yaml

* update components/pipeline-service/staging/stone-stg-m01/deploy.yaml

* update components/pipeline-service/staging/stone-stg-rh01/deploy.yaml

---------

Co-authored-by: rh-tap-build-team[bot] <127938674+rh-tap-build-team[bot]@users.noreply.github.com>
@amisstea
Copy link
Contributor

Closing this obsolete PR.

@amisstea amisstea closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisstea amisstea Awaiting requested review from amisstea

@avi-biton avi-biton Awaiting requested review from avi-biton

@hmariset hmariset Awaiting requested review from hmariset

Assignees

@amisstea amisstea

Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kousalya1998 @amisstea @hmariset @openshift-merge-robot