Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFBUGS-319: Fix rdspec and protectedpvcs condition #387

Merged
merged 6 commits into from
Nov 19, 2024
Merged

DFBUGS-319: Fix rdspec and protectedpvcs condition #387

merged 6 commits into from
Nov 19, 2024
+369 −282

Commits on Nov 4, 2024

  1. Fix VRG resource updates causing RDSpec list alternation 

    Fix an issue where the VRG resource was frequently updated, causing the RDSpec
to alternate between an empty and non-empty list. This behavior directly impacted
failover and relocation. If the list was empty during these actions, PVC restore
was skipped, leading to incomplete recovery.

Signed-off-by: Benamar Mekhissi <[email protected]>
(cherry picked from commit a974756)
    Benamar Mekhissi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    91441e4 View commit details
    Browse the repository at this point in the history

  2. Update function to return last operation result and error 

    This commit modifies the utility function that creates the ManifestWork to return
an additional value indicating the last operation result alongside the error. The
result can be one of three values: created, updated, or none. This change is
needed to track whether the ManifestWork resource was newly created, updated, or
left unchanged.

Signed-off-by: Benamar Mekhissi <[email protected]>
(cherry picked from commit c46cc59)
    Benamar Mekhissi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2c7f447 View commit details
    Browse the repository at this point in the history

  3. Unit test to validate RDSpec changes 

    Signed-off-by: Benamar Mekhissi <[email protected]>
(cherry picked from commit fcf6be9)
    Benamar Mekhissi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    fccb7a2 View commit details
    Browse the repository at this point in the history

  4. Fix rare issue with missing PVsRestored condition in ProtectedPVC. 

    In certain edge cases, ProtectedPVCs may fail to add the PVsRestored condition
permanently, causing the relocate process to get stuck in the WaitForReadiness
progression.

Signed-off-by: Benamar Mekhissi <[email protected]>
(cherry picked from commit d7f0b8f)
    Benamar Mekhissi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    77d1a96 View commit details
    Browse the repository at this point in the history

  5. Rename a function and fix error msgs 

    Signed-off-by: Benamar Mekhissi <[email protected]>
(cherry picked from commit aae3695)
    Benamar Mekhissi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ed68df8 View commit details
    Browse the repository at this point in the history

  6. Optimize VRG ManifestWork Handling to Prevent Redundant Updates 

    When ensuring the VRG ManifestWork, the process now begins by retrieving the VRG
from an existing ManifestWork, if available, and updating it as needed. If the
ManifestWork does not exist, it will be created. This update-instead-of-create
approach avoids overwriting other fields unintentionally and ensures consistency
by always starting from a base VRG state.

Signed-off-by: Benamar Mekhissi <[email protected]>
(cherry picked from commit b05e435)
    Benamar Mekhissi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    7cf7935 View commit details
    Browse the repository at this point in the history