DFBUGS-319: Fix rdspec and protectedpvcs condition

[BenamarMk]

This PR includes critical fixes for Cephfs workloads that occasionally caused the relocation to stall forever in the WaitForReadiness progression.

Key Changes:

1. Fix for RDSpec List Alternation
   Addressed an issue where frequent VRG resource updates caused the RDSpec list to alternate between empty and non-empty list. This inconsistency was leading to incomplete PVC restores during failover or relocation, halting the recovery process.

2. Fix for ProtectedPVC PVsRestored Condition
   In certain edge cases, ProtectedPVCs were failing to add the PVsRestored condition permanently, which caused the relocate process to get stuck in the WaitForReadiness progression. This fix ensures the condition is consistently applied, preventing the relocation from stalling.

3. Refactor of ManifestWork Creation Function
   The utility function that creates ManifestWork has been refactored to return the last operation result (created, updated, or none) alongside any errors. This change allows tracking of whether a ManifestWork resource was newly created, updated, or left unchanged.

JIRA: https://issues.redhat.com//browse/DFBUGS-319

[openshift-ci]

@BenamarMk: This pull request references Bugzilla bug 2319334, which is invalid:

• expected the bug to target the "ODF 4.17.0" release, but it targets "ODF 4.18.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2319334: Fix rdspec and protectedpvcs condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@BenamarMk: This pull request references Bugzilla bug 2319334, which is invalid:

• expected the bug to target the "ODF 4.17.0" release, but it targets "ODF 4.18.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2319334: Fix rdspec and protectedpvcs condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@BenamarMk: An error was encountered updating to the POST state for bug 2321510 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

code 109: You are not permitted to edit bugs in product Red Hat OpenShift Data Foundation.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2321510: Fix rdspec and protectedpvcs condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@BenamarMk: This pull request references Bugzilla bug 319, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to target the "ODF 4.17.0" release, but it targets "---" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (NOTABUG) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

DFBug 319: Fix rdspec and protectedpvcs condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@BenamarMk: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

DFBUGS-319: Fix rdspec and protectedpvcs condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@BenamarMk: This pull request references [Jira Issue DFBUGS-319](https://issues.redhat.com//browse/DFBUGS-319), which is invalid:

• expected the bug to target the "odf-4.17" version, but no target version was set
• expected dependent [Jira Issue DFBUGS-309](https://issues.redhat.com//browse/DFBUGS-309) to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead
• expected dependent [Jira Issue DFBUGS-309](https://issues.redhat.com//browse/DFBUGS-309) to target a version in odf-4.18, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This PR includes critical fixes for Cephfs workloads that occasionally caused the relocation to stall forever in the WaitForReadiness progression.

Key Changes:

1. Fix for RDSpec List Alternation
   Addressed an issue where frequent VRG resource updates caused the RDSpec list to alternate between empty and non-empty list. This inconsistency was leading to incomplete PVC restores during failover or relocation, halting the recovery process.

2. Fix for ProtectedPVC PVsRestored Condition
   In certain edge cases, ProtectedPVCs were failing to add the PVsRestored condition permanently, which caused the relocate process to get stuck in the WaitForReadiness progression. This fix ensures the condition is consistently applied, preventing the relocation from stalling.

3. Refactor of ManifestWork Creation Function
   The utility function that creates ManifestWork has been refactored to return the last operation result (created, updated, or none) alongside any errors. This change allows tracking of whether a ManifestWork resource was newly created, updated, or left unchanged.

Fixes Bug: 2319334

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@BenamarMk: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

DFBUGS 319: Fix rdspec and protectedpvcs condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@BenamarMk: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

This PR includes critical fixes for Cephfs workloads that occasionally caused the relocation to stall forever in the WaitForReadiness progression.

Key Changes:

1. Fix for RDSpec List Alternation
   Addressed an issue where frequent VRG resource updates caused the RDSpec list to alternate between empty and non-empty list. This inconsistency was leading to incomplete PVC restores during failover or relocation, halting the recovery process.

2. Fix for ProtectedPVC PVsRestored Condition
   In certain edge cases, ProtectedPVCs were failing to add the PVsRestored condition permanently, which caused the relocate process to get stuck in the WaitForReadiness progression. This fix ensures the condition is consistently applied, preventing the relocation from stalling.

3. Refactor of ManifestWork Creation Function
   The utility function that creates ManifestWork has been refactored to return the last operation result (created, updated, or none) alongside any errors. This change allows tracking of whether a ManifestWork resource was newly created, updated, or left unchanged.

Fixes Bug: 2319334

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@BenamarMk: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

DFBUGS-319: Fix rdspec and protectedpvcs condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@BenamarMk: This pull request references [Jira Issue DFBUGS-319](https://issues.redhat.com//browse/DFBUGS-319), which is invalid:

• expected the bug to target the "odf-4.17" version, but no target version was set
• expected dependent [Jira Issue DFBUGS-309](https://issues.redhat.com//browse/DFBUGS-309) to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead
• expected dependent [Jira Issue DFBUGS-309](https://issues.redhat.com//browse/DFBUGS-309) to target a version in odf-4.18, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This PR includes critical fixes for Cephfs workloads that occasionally caused the relocation to stall forever in the WaitForReadiness progression.

Key Changes:

1. Fix for RDSpec List Alternation
   Addressed an issue where frequent VRG resource updates caused the RDSpec list to alternate between empty and non-empty list. This inconsistency was leading to incomplete PVC restores during failover or relocation, halting the recovery process.

2. Fix for ProtectedPVC PVsRestored Condition
   In certain edge cases, ProtectedPVCs were failing to add the PVsRestored condition permanently, which caused the relocate process to get stuck in the WaitForReadiness progression. This fix ensures the condition is consistently applied, preventing the relocation from stalling.

3. Refactor of ManifestWork Creation Function
   The utility function that creates ManifestWork has been refactored to return the last operation result (created, updated, or none) alongside any errors. This change allows tracking of whether a ManifestWork resource was newly created, updated, or left unchanged.

Fixes Bug: 2319334

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@BenamarMk: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

JIRA: https://issues.redhat.com//browse/DFBUGS-319: Fix rdspec and protectedpvcs condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@BenamarMk: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

DFBUGS-319: Fix rdspec and protectedpvcs condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@BenamarMk: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

DFBUGS-319: Fix rdspec and protectedpvcs condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@BenamarMk: This pull request references [Jira Issue DFBUGS-319](https://issues.redhat.com//browse/DFBUGS-319), which is invalid:

• expected the bug to target the "odf-4.17" version, but no target version was set
• expected dependent [Jira Issue DFBUGS-309](https://issues.redhat.com//browse/DFBUGS-309) to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead
• expected dependent [Jira Issue DFBUGS-309](https://issues.redhat.com//browse/DFBUGS-309) to target a version in odf-4.18, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This PR includes critical fixes for Cephfs workloads that occasionally caused the relocation to stall forever in the WaitForReadiness progression.

Key Changes:

1. Fix for RDSpec List Alternation
   Addressed an issue where frequent VRG resource updates caused the RDSpec list to alternate between empty and non-empty list. This inconsistency was leading to incomplete PVC restores during failover or relocation, halting the recovery process.

2. Fix for ProtectedPVC PVsRestored Condition
   In certain edge cases, ProtectedPVCs were failing to add the PVsRestored condition permanently, which caused the relocate process to get stuck in the WaitForReadiness progression. This fix ensures the condition is consistently applied, preventing the relocation from stalling.

3. Refactor of ManifestWork Creation Function
   The utility function that creates ManifestWork has been refactored to return the last operation result (created, updated, or none) alongside any errors. This change allows tracking of whether a ManifestWork resource was newly created, updated, or left unchanged.

JIRA: https://issues.redhat.com//browse/DFBUGS-319

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@BenamarMk: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

DFBUGS-319: Fix rdspec and protectedpvcs condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@BenamarMk: This pull request references [Jira Issue DFBUGS-319](https://issues.redhat.com//browse/DFBUGS-319), which is invalid:

• expected the bug to target the "odf-4.17" version, but no target version was set
• expected dependent [Jira Issue DFBUGS-309](https://issues.redhat.com//browse/DFBUGS-309) to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead
• expected dependent [Jira Issue DFBUGS-309](https://issues.redhat.com//browse/DFBUGS-309) to target a version in odf-4.18, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

JIRA: https://issues.redhat.com//browse/DFBUGS-319

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@BenamarMk: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

DFBUGS-319: Fix rdspec and protectedpvcs condition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@BenamarMk: This pull request references [Jira Issue DFBUGS-319](https://issues.redhat.com//browse/DFBUGS-319), which is invalid:

• expected the bug to target the "odf-4.17" version, but no target version was set
• expected dependent [Jira Issue DFBUGS-309](https://issues.redhat.com//browse/DFBUGS-309) to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead
• expected dependent [Jira Issue DFBUGS-309](https://issues.redhat.com//browse/DFBUGS-309) to target a version in odf-4.18, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This PR includes critical fixes for Cephfs workloads that occasionally caused the relocation to stall forever in the WaitForReadiness progression.

Key Changes:

1. Fix for RDSpec List Alternation
   Addressed an issue where frequent VRG resource updates caused the RDSpec list to alternate between empty and non-empty list. This inconsistency was leading to incomplete PVC restores during failover or relocation, halting the recovery process.

2. Fix for ProtectedPVC PVsRestored Condition
   In certain edge cases, ProtectedPVCs were failing to add the PVsRestored condition permanently, which caused the relocate process to get stuck in the WaitForReadiness progression. This fix ensures the condition is consistently applied, preventing the relocation from stalling.

3. Refactor of ManifestWork Creation Function
   The utility function that creates ManifestWork has been refactored to return the last operation result (created, updated, or none) alongside any errors. This change allows tracking of whether a ManifestWork resource was newly created, updated, or left unchanged.

JIRA: https://issues.redhat.com//browse/DFBUGS-319

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[kseegerrh]

/jira refresh

[openshift-ci-robot]

@kseegerrh: This pull request references [Jira Issue DFBUGS-319](https://issues.redhat.com//browse/DFBUGS-319), which is invalid:

• expected the bug to target the "odf-4.17" version, but no target version was set
• expected dependent [Jira Issue DFBUGS-309](https://issues.redhat.com//browse/DFBUGS-309) to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead
• expected dependent [Jira Issue DFBUGS-309](https://issues.redhat.com//browse/DFBUGS-309) to target a version in odf-4.18, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[kseegerrh]

/jira refresh

[openshift-ci-robot]

@kseegerrh: This pull request references [Jira Issue DFBUGS-319](https://issues.redhat.com//browse/DFBUGS-319), which is invalid:

• expected dependent [Jira Issue DFBUGS-309](https://issues.redhat.com//browse/DFBUGS-309) to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead
• expected dependent [Jira Issue DFBUGS-309](https://issues.redhat.com//browse/DFBUGS-309) to target a version in odf-4.18, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[BenamarMk]

/jira refresh

[openshift-ci-robot]

@BenamarMk: This pull request references [Jira Issue DFBUGS-319](https://issues.redhat.com//browse/DFBUGS-319), which is invalid:

• expected the bug to target the "odf-4.17" version, but no target version was set
• expected dependent [Jira Issue DFBUGS-309](https://issues.redhat.com//browse/DFBUGS-309) to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[agarwal-mudit]

/jira refresh

[openshift-ci-robot]

@agarwal-mudit: This pull request references [Jira Issue DFBUGS-319](https://issues.redhat.com//browse/DFBUGS-319), which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (odf-4.17.1) matches configured target version for branch (odf-4.17.1)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@agarwal-mudit: This pull request references [Jira Issue DFBUGS-319](https://issues.redhat.com//browse/DFBUGS-319), which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (odf-4.17.1) matches configured target version for branch (odf-4.17.1)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: BenamarMk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@BenamarMk: [Jira Issue DFBUGS-319](https://issues.redhat.com//browse/DFBUGS-319): All pull requests linked via external trackers have merged:

• red-hat-storage/ramen#387

[Jira Issue DFBUGS-319](https://issues.redhat.com//browse/DFBUGS-319) has been moved to the MODIFIED state.

In response to this:

This PR includes critical fixes for Cephfs workloads that occasionally caused the relocation to stall forever in the WaitForReadiness progression.

Key Changes:

1. Fix for RDSpec List Alternation
   Addressed an issue where frequent VRG resource updates caused the RDSpec list to alternate between empty and non-empty list. This inconsistency was leading to incomplete PVC restores during failover or relocation, halting the recovery process.

2. Fix for ProtectedPVC PVsRestored Condition
   In certain edge cases, ProtectedPVCs were failing to add the PVsRestored condition permanently, which caused the relocate process to get stuck in the WaitForReadiness progression. This fix ensures the condition is consistently applied, preventing the relocation from stalling.

3. Refactor of ManifestWork Creation Function
   The utility function that creates ManifestWork has been refactored to return the last operation result (created, updated, or none) alongside any errors. This change allows tracking of whether a ManifestWork resource was newly created, updated, or left unchanged.

JIRA: https://issues.redhat.com//browse/DFBUGS-319

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.