Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit some forgotten pkl-related changes #3616

Merged
merged 1 commit into from
Jun 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/build-workflows.ps1
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Get-ChildItem -Path './pkl-workflows' -Filter *.pkl -File -Name | ForEach-Object {
&pkl eval ./pkl-workflows/$_ -o "./workflows/$($_.Replace('pkl', 'yml'))"
}
2 changes: 2 additions & 0 deletions .github/pkl-workflows/Readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ brew install pkl

## Building the workflows

Run `pwsh .github/build-workflows.ps1` or the following bash script if you don't have/use powershell:

```bash
cd $SolutionDir/.github/pkl-workflows
for file in *.pkl ; do pkl eval $file -o ../workflows/$(echo $file | sed s/pkl/yml/) ; done
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions Tools/DeployApps/BaasClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1099,10 +1099,8 @@ private async Task<string> StartContainer(string differentiator)

private async Task<ContainerInfo> WaitForContainer(string containerId, int maxRetries = 100)
{
while (maxRetries > 0)
for (var i = 0; i < maxRetries; i++)
{
maxRetries -= 1;

try
{
var containers = await GetContainers();
Expand All @@ -1125,7 +1123,7 @@ private async Task<ContainerInfo> WaitForContainer(string containerId, int maxRe
await Task.Delay(2000);
}

throw new Exception($"Container with id={containerId} was not found or ready after 100 retries");
throw new Exception($"Container with id={containerId} was not found or ready after {maxRetries} retries");
}

private async Task<T> CallEndpointAsync<T>(HttpMethod method, string relativePath, object? payload = null)
Expand Down
Loading