Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit some forgotten pkl-related changes #3616

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Commit some forgotten pkl-related changes #3616

merged 1 commit into from
Jun 14, 2024

Conversation

nirinchev
Copy link
Member

Description

Had those staged, but seems I forgot to commit them before merging #3603.

TODO

  • Changelog entry
  • Tests

@nirinchev nirinchev added no-changelog Used to skip the changelog check no-jira-ticket Skip checking the PR title for Jira reference labels Jun 6, 2024
@nirinchev nirinchev requested a review from papafe June 6, 2024 07:06
@cla-bot cla-bot bot added the cla: yes label Jun 6, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jun 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9396578823

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.27%
Totals Coverage Status
Change from base Build 9350004469: 0.0%
Covered Lines: 6831
Relevant Lines: 8261
💛 - Coveralls

@nirinchev nirinchev merged commit 853b3fc into main Jun 14, 2024
65 of 70 checks passed
@nirinchev nirinchev deleted the ni/pkl-followup branch June 14, 2024 00:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@papafe papafe papafe approved these changes

Assignees

@nirinchev nirinchev

Labels
cla: yes no-changelog Used to skip the changelog check no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nirinchev @papafe