-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add rasterization and interpolation features #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement vectorized interpolation for colors, both horizontally and vertically. - Include robust error handling to manage edge cases and invalid inputs in interpolation functions. - Develop comprehensive unit tests to validate the rasterization and interpolation functionality. - Ensure tests cover a variety of scenarios, including edge cases and expected failures.
Olaf-Wolf3D
requested changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the right direction, I like how the interpolation in set up into several functions. Only a few bits and pieces requested for change.
- Fixed naming output for profiler to not have invalid characters. - Addressed feedback for docstrings and some lines.
Olaf-Wolf3D
requested changes
Dec 1, 2023
return new array each time to avoid side effects on fixtures
avoid implementation detail in variable name. rename cleanup func to use imperative mood.
to avoid side-effects, inplace is False by default.
RGB, RGBA, GRAYSCALE
Olaf-Wolf3D
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rasterizer of pixel data (colors, normals, alpha), into a W,H image. The rasterizer interpolates the value between points and inside the new triangle.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.
Checklist
Task: TECHART-329