feat: identify overlapping vertices at UV seams

src/readyplayerme/meshops/mesh.py

@@ -60,11 +60,21 @@ def get_overlapping_vertices(
     :param precision: Tolerance for considering positions as overlapping.
     :return: A list of grouped vertices that share position.
     """
-    try:
-        selected_vertices = vertices_pos if indices is None else vertices_pos[indices]
-    except IndexError as error:
-        msg = "Indices must be within bounds of vertices array."
-        raise IndexError(msg) from error
+    # Not using try / except because when using an index of -1 gets the last element and creates a false positive
+    if indices is None:
+        selected_vertices = vertices_pos
+    else:
+        if len(indices) == 0:
+            return []
+        if np.any(indices < 0):
+            msg = "Negative index value is not allowed."
+            raise IndexError(msg)
+
+        if np.max(indices) >= len(vertices_pos):
+            msg = "Index is out of bounds."
+            raise IndexError(msg)
+
+        selected_vertices = vertices_pos[indices]
 
     tree = cKDTree(selected_vertices)
 

tests/readyplayerme/meshops/unit/test_mesh.py

@@ -105,10 +105,17 @@ def test_get_overlapping_vertices(
         assert np.array_equal(group, exp_group), f"Grouped vertices {group} do not match expected {exp_group}"
 
 
-def test_get_overlapping_vertices_index_error():
-    """Test the get_overlapping_vertices function with indices that are out of bounds for the vertices."""
+@pytest.mark.parametrize(
+    "indices",
+    [
+        # Case with index out of bounds (higher than max)
+        np.array([0, 3], dtype=np.uint16),
+        # Case with index out of bounds (negative index)
+        np.array([0, -1], dtype=np.int32),  # Using int32 to allow negative values
+    ],
+)
+def test_get_overlapping_vertices_error_handling(indices):
+    """Test that get_overlapping_vertices function raises an exception for out of bounds indices."""
     vertices = np.array([[1.0, 1.0, 1.0], [1.0, 1.0, 1.0]])
-    indices = np.array([2, 3, -4])
-
     with pytest.raises(IndexError):
         mesh.get_overlapping_vertices(vertices, indices)