feat: identify overlapping vertices at UV seams #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce `get_overlapping_vertices` for vertex grouping. - Account for floating-point imprecision in vertex positions. - Ensure accurate identification without false positives. - Function returns a list of arrays with vertex indices. test: ensure accurate overlapping vertex identification - Verify accurate detection of overlapping vertices. - Confirm no false positives are returned. - Test with varying mesh complexities. - Check for match detection within a few milliseconds.
- Update function to process all vertices if indices are not provided. - Handle cases with 'None' or empty list for indices. - Improve function's flexibility and robustness for various cases. test: add new cases for get_overlapping_vertices function - Include unit tests for scenarios with 'None' or empty indices. - Ensure function behaves as expected in these special cases. - Enhance reliability and test coverage.
Olaf-Wolf3D
reviewed
Nov 16, 2023
Olaf-Wolf3D
reviewed
Nov 16, 2023
Olaf-Wolf3D
reviewed
Nov 16, 2023
Olaf-Wolf3D
reviewed
Nov 16, 2023
imprecision test is failing with current implementation
Olaf-Wolf3D
requested changes
Nov 16, 2023
- Implement a tolerance parameter in get_overlapping_vertices for better vertex grouping. - Add tests to verify the new functionality.
Olaf-Wolf3D
requested changes
Nov 17, 2023
Olaf-Wolf3D
reviewed
Nov 17, 2023
Add test for IndexError in get_overlapping_vertices
fix type of expected in test_get_overlapping_vertices to IndexGroups
Olaf-Wolf3D
approved these changes
Nov 17, 2023
- Handle empty and negative indices in get_overlapping_vertices. - Include additional tests to cover new checks.
Olaf-Wolf3D
reviewed
Nov 21, 2023
Comment on lines
+63
to
+77
| # Not using try / except because when using an index of -1 gets the last element and creates a false positive | ||
| if indices is None: | ||
| selected_vertices = vertices_pos | ||
| else: | ||
| if len(indices) == 0: | ||
| return [] | ||
| if np.any(indices < 0): | ||
| msg = "Negative index value is not allowed." | ||
| raise IndexError(msg) | ||
|
|
||
| if np.max(indices) >= len(vertices_pos): | ||
| msg = "Index is out of bounds." | ||
| raise IndexError(msg) | ||
|
|
||
| selected_vertices = vertices_pos[indices] |
There was a problem hiding this comment.
unnnessary and pushed after approval.
| # Case with index out of bounds (higher than max) | ||
| np.array([0, 3], dtype=np.uint16), | ||
| # Case with index out of bounds (negative index) | ||
| np.array([0, -1], dtype=np.int32), # Using int32 to allow negative values |
There was a problem hiding this comment.
this should still be valid. Only negative indices that are out of bounds should raise. -1 is not out of bounds in this example, neither is -2, but -3 would be out of bounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_overlapping_verticesfor vertex grouping.test: ensure accurate overlapping vertex identification
Description
We need to group the vertices that share the same 3D Position so we ca blend the vertex color.
This function is vital for the vertex color blending.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test Configuration:
Checklist