-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/attribute_to_image #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generalized solution to turn arbitrary color attributes into images using a UV layout
add empty line after module doc-string.
For better readability in UI and making sense of paramtrization
Do not include parameter type in function name
Now most extreme value, or 1, is used to scale relative to 0 as a fixed value.
center determines whether the positions are computed from the center of the mesh, while the uniform_scale determines whether to scale positions uniformly or independently along each axis.
tests were adjusted for new attribute normalization method
This is to debug whether the recent changes now pass through github action, because it passes on windows locally
try to appease mypy type checking gods
try to appease mypy type checking gods once again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress
Description
A generalized solution to turn arbitrary color attributes into images using a UV layout. Used for object space normal maps, and position maps, and can potentially be used for morphTargets, skin weights etc.
glTF files can store arbitrary attributes on vertices.
Task: TECHART-360
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested with hatch locally on Windows 11:
Checklist