Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/attribute_to_image #15

Merged
merged 16 commits into from
May 8, 2024
Merged

Feature/attribute_to_image #15

merged 16 commits into from
May 8, 2024

Conversation

Olaf-Wolf3D
Copy link
Collaborator

@Olaf-Wolf3D Olaf-Wolf3D commented Jan 9, 2024

Work in Progress

Description

A generalized solution to turn arbitrary color attributes into images using a UV layout. Used for object space normal maps, and position maps, and can potentially be used for morphTargets, skin weights etc.
glTF files can store arbitrary attributes on vertices.

Task: TECHART-360

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested with hatch locally on Windows 11:

hatch run all
  • Lint
  • Style & Format
  • Tests

Checklist

  • I confirm that the changes meet the user experience and goals outlined in the design plan (if there is one).
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have updated any version info, if necessary.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Olaf Haag added 2 commits January 9, 2024 15:11
generalized solution to turn arbitrary color attributes into images using a UV layout
@Olaf-Wolf3D Olaf-Wolf3D self-assigned this Jan 9, 2024
add empty line after module doc-string.
For better readability in UI and making sense of paramtrization
Do not include parameter type in function name
Now most extreme value, or 1, is used to scale relative to 0 as a fixed value.
center determines whether the positions are computed from the center of the mesh, while the uniform_scale determines whether to scale positions uniformly or independently along each axis.
tests were adjusted for new attribute normalization method
This is to debug whether the recent changes now pass through github action, because it passes on windows locally
@Olaf-Wolf3D Olaf-Wolf3D marked this pull request as ready for review May 8, 2024 10:50
try to appease mypy type checking gods
@Olaf-Wolf3D Olaf-Wolf3D marked this pull request as draft May 8, 2024 12:38
@Olaf-Wolf3D Olaf-Wolf3D marked this pull request as ready for review May 8, 2024 12:38
@Olaf-Wolf3D Olaf-Wolf3D marked this pull request as draft May 8, 2024 14:17
@Olaf-Wolf3D Olaf-Wolf3D marked this pull request as ready for review May 8, 2024 14:17
@Olaf-Wolf3D Olaf-Wolf3D merged commit 4a6fe8e into main May 8, 2024
@Olaf-Wolf3D Olaf-Wolf3D deleted the feature/attribute_to_image branch May 8, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant