Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/hero avatar to costume #12

Merged
merged 5 commits into from
Sep 29, 2023
Merged

Fix/hero avatar to costume #12

merged 5 commits into from
Sep 29, 2023

Conversation

TechyDaniel
Copy link
Contributor

@TechyDaniel TechyDaniel commented Sep 25, 2023

Changing naming from heroAvatar to costume.
https://ready-player-me.atlassian.net/browse/SRV-584

@TechyDaniel TechyDaniel self-assigned this Sep 25, 2023
@TechyDaniel TechyDaniel marked this pull request as ready for review September 25, 2023 11:50
schemas/assetCostume.schema.json Outdated Show resolved Hide resolved
schemas/assetCostume.schema.json Show resolved Hide resolved
@Olaf-Wolf3D Olaf-Wolf3D self-requested a review September 27, 2023 23:46
Copy link
Collaborator

@Olaf-Wolf3D Olaf-Wolf3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the duplicated line, then good to go.

schemas/assetCostume.schema.json Outdated Show resolved Hide resolved
@TechyDaniel TechyDaniel requested review from Olaf-Wolf3D and a team September 28, 2023 08:47
@TechyDaniel TechyDaniel merged commit 5137b36 into main Sep 29, 2023
@TechyDaniel TechyDaniel deleted the fix/HeroAvatar-to-costume branch September 29, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants