Fix/hero avatar to costume (#12)

* fix: according to the new agreement we changed naming from HeroAvatar to costume * fix: typo * fix : removed duplicates
readyplayerme · Sep 29, 2023 · 5137b36 · 5137b36
1 parent 39f45a9
commit 5137b36
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 17 deletions.
diff --git a/schemas/assetHeroAvatar.schema.json → schemas/assetCostume.schema.json b/schemas/assetHeroAvatar.schema.json → schemas/assetCostume.schema.json
@@ -1,8 +1,8 @@
 {
   "$schema": "https://json-schema.org/draft/2020-12/schema",
-  "$id": "assetHeroAvatar.schema.json",
-  "title": "Hero Avatar Asset",
-  "description": "A Ready Player Me glTF binary validation schema for a hero avatar.",
+  "$id": "assetCostume.schema.json",
+  "title": "Costume Asset",
+  "description": "A Ready Player Me glTF binary validation schema for a costume.",
   "type": "object",
   "properties": {
     "scenes": { "$ref": "scene.schema.json#/$defs/fullbodyOutfitScene" },
@@ -14,8 +14,8 @@
           "minimum": 1,
           "maximum": 30000,
           "errorMessage": {
-            "minimum": "Too few triangles! Hero avatars must have at least 1 triangle.",
-            "maximum": "Too many triangles (${0})! Hero avatars must have no more than a total of 30,000 triangles."
+            "minimum": "Too few triangles! This asset must have at least 1 triangle.",
+            "maximum": "Too many triangles (${0})! This asset must have no more than a total of 30,000 triangles."
           }
         },
         "properties": {
@@ -26,7 +26,7 @@
             "properties": {
               "name": {
                 "description": "Name of the mesh.",
-                "$ref": "meshNames.schema.json#/properties/heroAvatar"
+                "$ref": "meshNames.schema.json#/properties/costume"
               },
               "attributes": {
                 "$ref": "meshAttributes.schema.json#/properties/skinned"
@@ -222,8 +222,8 @@
           "minItems": 1,
           "maxItems": 13,
           "errorMessage": {
-            "minItems": "Missing mesh! Hero avatars must have at least 1 mesh.",
-            "maxItems": "Too many meshes! Hero avatars must have no more than 13 meshes."
+            "minItems": "Missing mesh! This asset must have at least 1 mesh.",
+            "maxItems": "Too many meshes! This asset must have no more than 13 meshes."
           }
         }
       }
@@ -239,7 +239,7 @@
             "properties": {
               "name": {
                 "description": "Name of the material.",
-                "$ref": "materialNames.schema.json#/properties/heroAvatar"
+                "$ref": "materialNames.schema.json#/properties/costume"
               },
               "textures": {
                 "$ref": "commonMaterial.schema.json#/$defs/allTextureChannels"
@@ -317,8 +317,8 @@
           "minItems": 1,
           "maxItems": 12,
           "errorMessage": {
-            "minItems": "Missing material! This avatar must have at least 1 material. Found ${/materials/properties/length}.",
-            "maxItems": "Too many materials! This avatar only supports up to 12 materials (eyes share a material). Found ${/materials/properties/length}."
+            "minItems": "Missing material! This asset must have at least 1 material. Found ${/materials/properties/length}.",
+            "maxItems": "Too many materials! This asset only supports up to 12 materials (eyes share a material). Found ${/materials/properties/length}."
           }
         }
       }

diff --git a/schemas/gltf-asset.schema.json b/schemas/gltf-asset.schema.json
@@ -23,15 +23,15 @@
         "hair",
         "headwear",
         "lipshape",
-        "heroAvatar",
+        "costume",
         "noseshape",
         "outfit",
         "shirt",
         "top"
       ],
       "errorMessage": {
         "type": "Asset type should be a string.",
-        "enum": "Asset type should be one of the following: beard, bottom, eye, eyebrows, eyeshape, facemask, faceshape, facewear, footwear, glasses, hair, headwear, lipshape, heroAvatar, noseshape, outfit, shirt, top. Found ${0}."
+        "enum": "Asset type should be one of the following: beard, bottom, eye, eyebrows, eyeshape, facemask, faceshape, facewear, footwear, glasses, hair, headwear, lipshape, costume, noseshape, outfit, shirt, top. Found ${0}."
       }
     },
     "transforms": {
@@ -162,10 +162,10 @@
     },
     {
       "if": {
-        "properties": { "assetType": { "const": "heroAvatar" } },
+        "properties": { "assetType": { "const": "costume" } },
         "required": ["assetType"]
       },
-      "then": { "$ref": "assetHeroAvatar.schema.json" }
+      "then": { "$ref": "assetCostume.schema.json" }
     },
     {
       "if": {

diff --git a/schemas/materialNames.schema.json b/schemas/materialNames.schema.json
@@ -15,7 +15,7 @@
     "modularBottom": { "type": "string", "const": "Wolf3D_Outfit_Bottom", "errorMessage": "Material name should be 'Wolf3D_Outfit_Bottom'. Found ${0} instead." },
     "modularFootwear": { "type": "string", "const": "Wolf3D_Outfit_Footwear", "errorMessage": "Material name should be 'Wolf3D_Outfit_Footwear'. Found ${0} instead." },
     "modularTop": { "type": "string", "const": "Wolf3D_Outfit_Top", "errorMessage": "Material name should be 'Wolf3D_Outfit_Top'. Found ${0} instead." },
-    "heroAvatar": {
+    "costume": {
       "enum": [
         "Wolf3D_Body",
         "Wolf3D_Eye",

diff --git a/schemas/meshNames.schema.json b/schemas/meshNames.schema.json
@@ -55,7 +55,7 @@
       "const": "Wolf3D_Outfit_Top",
       "errorMessage": "Mesh name should be 'Wolf3D_Outfit_Top'. Found ${0} instead."
     },
-    "heroAvatar": {
+    "costume": {
       "type": "string",
       "enum": [
         "EyeLeft",