Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(ruby): don't run bundle update #1034

Merged
merged 2 commits into from
Jul 26, 2024
Merged

ci(ruby): don't run bundle update #1034

merged 2 commits into from
Jul 26, 2024

Conversation

erunion
Copy link
Member

@erunion erunion commented Jul 26, 2024

🧰 Changes

We're running bundle update in our Ruby CI before running unit tests and this is upgrading all of our dependencies. Our usage of some of these dependencies apparently needs some work as every Ruby unit test fails on these updated deps.

@erunion erunion marked this pull request as ready for review July 26, 2024 23:07
@erunion erunion added bug Something isn't working ruby Issues related to our Ruby SDK labels Jul 26, 2024
@erunion erunion requested a review from a team July 26, 2024 23:08
.github/workflows/ruby.yml Outdated Show resolved Hide resolved
Copy link
Member

@gratcliff gratcliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@erunion erunion merged commit cd29dbe into main Jul 26, 2024
41 checks passed
@erunion erunion deleted the ci/fix-ruby-tests branch July 26, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ruby Issues related to our Ruby SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants