Skip to content

Commit

Permalink
ci(ruby): don't run bundle update (#1034)
Browse files Browse the repository at this point in the history
## 🧰 Changes

We're running `bundle update` in our Ruby CI before running unit tests
and this is upgrading all of our dependencies. Our usage of some of
these dependencies apparently needs some work as every Ruby unit test
fails on these updated deps.
  • Loading branch information
erunion authored Jul 26, 2024
1 parent 1dd6310 commit cd29dbe
Showing 1 changed file with 10 additions and 11 deletions.
21 changes: 10 additions & 11 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 16
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 16

- run: npm ci --ignore-scripts
- run: make test-metrics-ruby-rails
- run: make test-webhooks-ruby-rails
- run: npm ci --ignore-scripts
- run: make test-metrics-ruby-rails
- run: make test-webhooks-ruby-rails

- name: Cleanup
if: always()
run: docker-compose down
- name: Cleanup
if: always()
run: docker-compose down

build:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -55,7 +55,6 @@ jobs:
run: |
make install
gem install rack ${{ matrix.rack-version }}
bundle update
- name: Run linter
run: make lint
Expand Down

0 comments on commit cd29dbe

Please sign in to comment.