Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev script to skip linting and create-react-play when starting to… #1400

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

Angra974
Copy link
Contributor

@Angra974 Angra974 commented Dec 1, 2023

Description

Adding a dev script command in package.json to skip create-react-play each time we start the application.
We don't load the linting of files too as they are done now automatically with Husky, so we don't have problem with non linted files.

On linux system, often permission are change without the user intervention and when we are not use to linux, we didn't know how to handle the problem and lost time to figure out how to bypass it.

I've done at least more than 10 branches creation to test if i can push only my 2 files ( as currently in this branch ) instead of all the files in the project because the permission was changed on them and git pushed them too.

Fixes #1399

Type of change

add "dev" script in package.json
add .gitconfig to ignore file permission change in the system.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

1./ dev script
By using the command and see if the application is ok.
Start must be done at least one time, because create-react-play need to be run to create the index.js file in the plays folder.

2./ .gitconfig
By pushing the change online, and see if only the 2 modified files are committed and not all the files in the project.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
No specific test except running the program as usually.

Checklist:

  • I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 7cbb560
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/6579cde4df0c010009a40dc9
😎 Deploy Preview https://deploy-preview-1400--reactplayio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@joshi-kaushal joshi-kaushal merged commit 7d9a841 into main Dec 13, 2023
@priyankarpal priyankarpal deleted the add_dev_command branch December 27, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants