Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Bug report]: Linting error on QuizApp.tsx #1398

Closed
5 tasks done
kenselasie opened this issue Nov 28, 2023 · 5 comments
Closed
5 tasks done

🐛 [Bug report]: Linting error on QuizApp.tsx #1398

kenselasie opened this issue Nov 28, 2023 · 5 comments
Labels
💻 aspect: code Concerns the software code in the repository bug Something isn't working 🛠 goal: fix Bug fix

Comments

@kenselasie
Copy link

Descrcibe the bug?

After cloning the repo and running yarn start, there is a linting error on QuizApp.tsx

Steps to reproduce the bug?

  1. Clone repo
  2. yarn install
  3. yarn start

Expected behavior

App should run without any linting errors

Desktop (Please provide your system information)

OS: Mac
browser: Brave / Chrome

Mobile (Please provide your device information)

No response

Screenshot / Screenshare

Screenshot 2023-11-28 at 7 33 10 PM

Relevant log output

No response

Record

Code of Conduct

  • I agree to follow this project's Code of Conduct
@kenselasie kenselasie added bug Something isn't working 💻 aspect: code Concerns the software code in the repository 🚦status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix labels Nov 28, 2023
Copy link

To reduce notifications, issues are locked. Your issue will be unlocked when we add the label 🏁 status: ready for dev.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2023
@reactplay reactplay unlocked this conversation Nov 29, 2023
@priyankarpal
Copy link
Member

@kenselasie
Copy link
Author

kenselasie commented Nov 29, 2023

Readme says "...However make sure that you run start script at least once before committing your code. Code with linter error may not be reviewed."

But project wont run with this lint error not fixed, and future commits may not be merged.

@priyankarpal
Copy link
Member

check the PR #1400

@priyankarpal priyankarpal removed the 🚦status: awaiting triage Has not been triaged & therefore, not ready for work label Dec 2, 2023
@Angra974
Copy link
Contributor

Angra974 commented Dec 2, 2023

Usually, this notification is when something was submitted without formatting and escape from linting.
We have some ways to bypass the linting without husky running.
It's not the good way but sometimes you need to do it, or you do it without thinking about it.
One solution is the application was submitted without a prior installation so husky package is not installed and won't run.
The second solution is to tell git to not use husky.

Currently,
you need, i think to run a "yarn format" to correct the files with prettier as it seems like some identation are not right in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository bug Something isn't working 🛠 goal: fix Bug fix
Projects
None yet
Development

No branches or pull requests

3 participants