Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup warnings on eslint. Formatted all and modified a typo for cre… #1337

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

Angra974
Copy link
Contributor

@Angra974 Angra974 commented Oct 14, 2023

Description

When starting the application, some warnings come to us.
With new update of Eslint, these warnings come into errors and you can't continue to use the application.

So, this PR is intended to resolve these issues

Fixes #1239

Type of change

Delete unused variables.
As i've reverted back to the main branch, eslint configuration and an updated package.json files with eslint update inside was use.
In this case, some formatting was done in the same time than the correction for the unused variables.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Run :
yarnlint
check for errors/warnings
Clean up errors/warnings
yarn format
yarn lint
check for error/warnings
yarn format
yarn lint

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

Capture d’écran du 2023-10-14 03-02-07

![Capture d’écran du 2023-10-14 03-01-30](https://github.com/reactplay/react-play/assets/48807534/92fc870f-a291-4586-a12c-d66fbf3ef2

Capture d’écran du 2023-10-14 19-14-58

Uploading Capture d’écran du 2023-10-14 19-37-20.png…
be)

As i've refactored a little bit more the Multiplayer Tic-tac-toe, i've played with the play after run to check if no problem occurs.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@netlify
Copy link

netlify bot commented Oct 14, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit cb93edd
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/652ca4c208d3b00008c720eb
😎 Deploy Preview https://deploy-preview-1337--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Angra974
Copy link
Contributor Author

Seems like I didn't sent the file with the modification for the typo in the form with this PR. So i've deleted the related image.
Will do it in another PR later.

@priyankarpal
Copy link
Member

Seems like I didn't sent the file with the modification for the typo in the form with this PR. So i've deleted the related image. Will do it in another PR later.

ok

@atapas atapas merged commit f280904 into main Oct 16, 2023
4 of 5 checks passed
@atapas atapas deleted the clean_up_warnings branch October 16, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants