Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to clean eslint/prettier warnings and errors #1334

Closed
wants to merge 2 commits into from

Conversation

Angra974
Copy link
Contributor

@Angra974 Angra974 commented Oct 13, 2023

Description

When starting the application, some warnings come to us.
With new update of Eslint, these warnings come into errors and you can't continue to use the application.

So, this PR is intended to resolve these issues

Fixes #1239

Type of change

Delete unused variables.
As i've reverted back to the main branch, eslint configuration and an updated package.json files with eslint update inside was use.
In this case, some formatting was done in the same time than the correction for the unused variables.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Run pnpm lint
check for errors/warnings
Clean up errors/warnings
run pnpm lint
check for error/warnings

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

Capture d’écran du 2023-10-14 03-02-07

Capture d’écran du 2023-10-14 03-01-30

@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for reactplayio failed.

Name Link
🔨 Latest commit 845ac7a
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/652a8062deb938000884031b

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@priyankarpal
Copy link
Member

@Angra974 please check the issue
image

@priyankarpal priyankarpal added the changes required need to change some thing label Oct 14, 2023
@Angra974
Copy link
Contributor Author

Hi. I'm on it, just gone to take a little rest.
I think the problem is because the current version of eslint in the server was not the same on my computer.
When switching back to the main branch before creating a new one, i've stayed with the new version of estlint-prettier

I'm trying to install a clean directory before doing it again.

@Angra974
Copy link
Contributor Author

Waiting for #1333 to be merged.

@Angra974 Angra974 closed this Oct 14, 2023
@Angra974 Angra974 deleted the clean_up_warnings branch October 14, 2023 16:56
@Angra974
Copy link
Contributor Author

@Angra974 please check the issue image

Moved to #1337
This one was closed and delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants