-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplicate key in tabs overflow menu #444
Comments
you can reproduce it in the above example. also it only happens for 1 or 2 frames, and when you actually open the dropdown, you will never see the duplicated item. So it might also be some timing issue between react hooks that messed up with the measuring. |
PR is welcome |
Can we get the PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in this function, sometimes the startIndex is bigger than the endIndex, causing the menu for hiddenTabs in TabNavList to have duplicated items.
I guess some tab extra element with user defined css can cause it to measure things incorrectly.
tabs/src/hooks/useVisibleRange.ts
Lines 42 to 61 in a4ce7c4
could we add a simple protection like
The text was updated successfully, but these errors were encountered: