Overflow menu item key duplicates

[embeoo]

I've got an issue with console warnings for duplicate keys on the overflow menu items.
I can't reproduce in your example (no react?) but in this unrelated sandbox:
https://codesandbox.io/s/0l2oc

1 Open devtools/console
2 Click to add one tab
3 Shrink view to get overflow menu button
4 Click overflow menu button to view menu (no need to select anything)
5 Shrink view to be smaller than 1 tab's width

Console will be full of 'Encountered two children with the same key, tab1' warnings.

[embeoo]

And I thought it was so simple and clear..
With shrinking view, I mean making the white browser emulator pane less wide.Attached an image of the end result.
Is there anything about the reproduction you think is more unclear / the reason you can't reproduce?

[rinick]

It's an issue in rc-tabs lib, I created a ticket there

react-component/tabs#444

[embeoo]

@rinick Hi, would you consider making a pull request with the change you proposed in the rc-tabs issue above?

[rinick]

@rinick Hi, would you consider making a pull request with the change you proposed in the rc-tabs issue above?

I did. just check the links in the above issue.

If you really need this PR approved ASAP, you can try these

1. create a test case to reproduce it without rc-dock, maybe with only rc-tabs, or with antd tabs component
2. find a way to increase the code coverage for the PR.

If that's too hard, you can use patch-package to fix that issue locally
https://www.npmjs.com/package/patch-package

[embeoo]

My bad, I did not check, thought it stalled after the welcome of a PR.

Thanks, I'll see if I can contribute.