Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure startIndex <= endIndex when measuring visible tabs #454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rinick
Copy link
Contributor

@rinick rinick commented Dec 13, 2021

resolves issue: #444

@vercel
Copy link

vercel bot commented Dec 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/tabs/BMMQgGTCGZTXX1EFz44mJfbA5nCx
✅ Preview: https://tabs-git-fork-rinick-patch-1-react-component.vercel.app

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #454 (7038242) into master (3aeba5a) will decrease coverage by 0.17%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   99.47%   99.30%   -0.18%     
==========================================
  Files          13       13              
  Lines         570      572       +2     
  Branches      143      144       +1     
==========================================
+ Hits          567      568       +1     
- Misses          3        4       +1     
Impacted Files Coverage Δ
src/hooks/useVisibleRange.ts 97.14% <50.00%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aeba5a...7038242. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Feb 16, 2022

Could you add a test case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants