Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated Discovery.launch example with xrn:firebolt:application-type #187

Merged
merged 2 commits into from
Oct 10, 2023
Merged

fix: Updated Discovery.launch example with xrn:firebolt:application-type #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8d8a2b
fix: Updated Discovery.launch example with xrn:firebolt:application-type
kevinshahfws Sep 27, 2023
3210a92
fix: addressed review comments
kevinshahfws Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 11 additions & 11 deletions src/openrpc/discovery.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@
"schema": {
"$ref": "https://meta.comcast.com/firebolt/discovery#/definitions/PurchasedContentResult"
},
"summary": "The data for the purachasedContent"
"summary": "The data for the purchasedContent"
}
],
"result": {
Expand Down Expand Up @@ -971,7 +971,7 @@
]
}
],
"summary": "Launch or foreground the specified app, and optionally instructs it to navigate to the specified user action",
"summary": "Launch or foreground the specified app, and optionally instructs it to navigate to the specified user action. \n For the Primary Experience, the appId can be any one of: \n\n - xrn:firebolt:application-type:main \n\n - xrn:firebolt:application-type:settings",
"params": [
{
"name": "appId",
Expand Down Expand Up @@ -1079,7 +1079,7 @@
"params": [
{
"name": "appId",
"value": "urn:firebolt:apps:main"
"value": "xrn:firebolt:application-type:main"
},
{
"name": "intent",
Expand All @@ -1106,7 +1106,7 @@
"params": [
{
"name": "appId",
"value": "urn:firebolt:apps:main"
"value": "xrn:firebolt:application-type:main"
},
{
"name": "intent",
Expand All @@ -1131,7 +1131,7 @@
"params": [
{
"name": "appId",
"value": "urn:firebolt:apps:main"
"value": "xrn:firebolt:application-type:main"
},
{
"name": "intent",
Expand All @@ -1153,7 +1153,7 @@
"params": [
{
"name": "appId",
"value": "urn:firebolt:apps:main"
"value": "xrn:firebolt:application-type:main"
},
{
"name": "intent",
Expand All @@ -1175,7 +1175,7 @@
"params": [
{
"name": "appId",
"value": "urn:firebolt:apps:main"
"value": "xrn:firebolt:application-type:settings "
},
{
"name": "intent",
Expand All @@ -1200,7 +1200,7 @@
"params": [
{
"name": "appId",
"value": "urn:firebolt:apps:main"
"value": "xrn:firebolt:application-type:main"
},
{
"name": "intent",
Expand All @@ -1221,11 +1221,11 @@
}
},
{
"name": "Launch the Aggregated Experience to the App Store details page for a specfic app with the ID 'foo'.",
"name": "Launch the Aggregated Experience to the App Store details page for a specific app with the ID 'foo'.",
"params": [
{
"name": "appId",
"value": "urn:firebolt:apps:main"
"value": "xrn:firebolt:application-type:main "
},
{
"name": "intent",
Expand Down Expand Up @@ -1302,7 +1302,7 @@
]
}
],
"summary": "Inform the platform that your user is signed in, for increased visiblity in search & discovery. Sign-in state is used separately from what content can be access through entitlements and availabilities. Sign-in state may be used when deciding whether to choose this app to handle a user intent. For instance, if the user tries to launch something generic like playing music from an artist, only a signed-in app will be chosen. If the user wants to tune to a channel, only a signed-in app will be chosen to handle that intent. While signIn can optionally include entitlements as those typically change at signIn time, it is recommended to make a separate call to Discovery.contentAccess for entitlements. signIn is not only for when a user explicitly enters login credentials. If an app does not require any credentials from the user to consume content, such as in a free app, then the app should call signIn immediately on launch.",
"summary": "Inform the platform that your user is signed in, for increased visibility in search & discovery. Sign-in state is used separately from what content can be access through entitlements and availabilities. Sign-in state may be used when deciding whether to choose this app to handle a user intent. For instance, if the user tries to launch something generic like playing music from an artist, only a signed-in app will be chosen. If the user wants to tune to a channel, only a signed-in app will be chosen to handle that intent. While signIn can optionally include entitlements as those typically change at signIn time, it is recommended to make a separate call to Discovery.contentAccess for entitlements. signIn is not only for when a user explicitly enters login credentials. If an app does not require any credentials from the user to consume content, such as in a free app, then the app should call signIn immediately on launch.",
"params": [
{
"name": "entitlements",
Expand Down
Loading