fix: Updated Discovery.launch example with xrn:firebolt:application-type #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlacivita
requested changes
Sep 28, 2023
src/openrpc/discovery.json
Outdated
| @@ -971,7 +971,7 @@ | |||
| ] | |||
| } | |||
| ], | |||
| "summary": "Launch or foreground the specified app, and optionally instructs it to navigate to the specified user action", | |||
| "summary": "Launch or foreground the specified app, and optionally instructs it to navigate to the specified user action. \n For the Primary Experience, the appId can any one of <br/> urn:firebolt:apps:main <br/> xrn:firebolt:application-type:main <br/> or xrn:firebolt:application-type:settings", | |||
There was a problem hiding this comment.
We should not document urn:firebolt:apps:main as it's not to spec.
There was a problem hiding this comment.
And i think you're missing a word, maybe "For the Primary Experience, the appId can be any one of:"
Also, it's best to avoid HTML in markdown. Try using \n\n and putting the values in a list with - in front of each.
jlacivita
approved these changes
Oct 9, 2023
kevinshahfws
pushed a commit
that referenced
this pull request
Oct 10, 2023
# [0.18.0-next.3](v0.18.0-next.2...v0.18.0-next.3) (2023-10-10) ### Bug Fixes * Updated Discovery.launch example with xrn:firebolt:application-type ([#187](#187)) ([4dbbab3](4dbbab3))
|
🎉 This PR is included in version 0.18.0-next.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
kevinshahfws
pushed a commit
that referenced
this pull request
Nov 3, 2023
# [1.0.0](v0.17.1...v1.0.0) (2023-11-03) ### Bug Fixes * Account.session params to be mandatory ([#196](#196)) ([fc5c638](fc5c638)) * CI looking for legacy 0.x version ([923d02a](923d02a)) * Permission schema with Capability as required ([74d9de9](74d9de9)) * Provider error ([#202](#202)) ([4666a5e](4666a5e)) * schemas version upgraded to 2.0.0-next.1 ([#199](#199)) ([b0fb8cf](b0fb8cf)) * Update schemas & 1.0.0 version! ([#200](#200)) ([ea29f33](ea29f33)) * Updated Discovery.launch example with xrn:firebolt:application-type ([#187](#187)) ([4dbbab3](4dbbab3)) * Updated metrics:distributor capability to could ([#185](#185)) ([9ca2206](9ca2206)) ### Features * Added optional parameter 'force' in usergrants.request ([#186](#186)) ([31801ca](31801ca)) * Play Intent ([#151](#151)) ([d1ddf3f](d1ddf3f)) ### BREAKING CHANGES * This is not really a breaking change, but 1.0 release!!!
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.