Skip to content
This repository has been archived by the owner on Jun 17, 2020. It is now read-only.

D> RChain Development for Bounties: VM primitives, CI integration #176

Closed
lapin7 opened this issue Nov 17, 2017 · 31 comments
Closed

D> RChain Development for Bounties: VM primitives, CI integration #176

lapin7 opened this issue Nov 17, 2017 · 31 comments
Assignees
Labels
Development splitting into core-dev, developer-education, ...? (guides: @dckc, ...)

Comments

@lapin7
Copy link
Contributor

lapin7 commented Nov 17, 2017

Jira Bounties

  • Story ROS-271 | Integrate into CI Pipeline
  • Bug ROS-270 | Fix C++ Rosette builds
  • Story ROS-266 | Make C++ Rosette VM read in an RBL file in addition to boot.rbl
  • Story ROS-253 | Create primitive definitions located in RBLString.cc
  • Story ROS-251 | Create primitive definitions located in RblStack.cc
  • Story ROS-250 | Create primitive definitions located in RblAtom.cc
  • Story ROS-247 | Create primitive definitions located in Queue.cc
  • Story ROS-246 | Create primitive definitions

The work on these issues requires that the community engage with the core development team. @dckc has experience with this engagement. So you can ask him how that goes.
Please, ask @MParlikar how to engage and how to become assigned to a ROS.
Please put regular comments hereunder, so that it's visible for the other members that you're working.

@MParlikar
Copy link

Please advise which ticket you wish to work on, and your Discord handle will be added to the ticket - so no one else will work on the ticket.

@lapin7
Copy link
Contributor Author

lapin7 commented Nov 17, 2017 via email

@dckc
Copy link
Contributor

dckc commented Nov 21, 2017

I spent a little time orienting myself to work on ROS-271 but eventually discovered @KentShikama has done the bulk of it: PR 52

For reference: https://travis-ci.org/rchain/rchain build logs

@dckc
Copy link
Contributor

dckc commented Nov 21, 2017

After discussion with @KentShikama, I put some more time in: rchain/rchain#54

time log: about 3 or 4 hrs tonight.

@dckc dckc changed the title RChain Development RChain Development: VM primitives, CI integration Nov 28, 2017
@rchain-travis
Copy link

Here is the wiki page for the Bounty tickets:
https://rchain.atlassian.net/wiki/spaces/CORE/pages/105938971/Bounties+for+Development+work

@rchain-travis rchain-travis changed the title RChain Development: VM primitives, CI integration RChain Development for Bounties: VM primitives, CI integration Nov 30, 2017
@lapin7
Copy link
Contributor Author

lapin7 commented Dec 4, 2017

@rchain-travis are you the same person as @travismorehead ??

@ghost
Copy link

ghost commented Dec 4, 2017

No, it's the build system. https://travis-ci.org/

@dckc
Copy link
Contributor

dckc commented Dec 4, 2017

the build system made #176 (comment) ???

@ghost
Copy link

ghost commented Dec 4, 2017

Oh, was Medha while logged into that account by accident.

@MParlikar
Copy link

MParlikar commented Dec 4, 2017 via email

@patrick727 patrick727 changed the title RChain Development for Bounties: VM primitives, CI integration D> RChain Development for Bounties: VM primitives, CI integration Dec 8, 2017
@dckc dckc added the Development splitting into core-dev, developer-education, ...? (guides: @dckc, ...) label Dec 9, 2017
@BelovedAquila
Copy link

@dckc how does it go please, want to see what contributions I can make to help resolve this issue

@BelovedAquila
Copy link

@MParlikar please would likewise want to know how to engage and be assigned to a ROS please .

@dckc
Copy link
Contributor

dckc commented Dec 26, 2017

@BelovedAquila which of the Jira bounties most interests you?

Before you start making any changes, have you checked out the code and gotten the tests running in your development environment?

@BelovedAquila
Copy link

@dckc no I haven't how do I do that

@dckc
Copy link
Contributor

dckc commented Dec 27, 2017

@BelovedAquila this issue is about collaborative software development in scala (or perhaps C++). Do you have experience with that? I can't tell from your github profile whether you do.

You check out the code like any other github project; see Propose changes to someone else's project. Then use sbt test in any of the subprojects under https://github.com/rchain/rchain.

@MParlikar
Copy link

@BelovedAquila Select a ROS ticket from the list of bounty tickets and advise in Discord (DM) or you may advise here. I will assign a label to your username (hopefully your Git and Discord handles are the same) on the ticket, so others will see that you are on it. You can also look at ROS-197, which was recently completed by a member also.

@MParlikar
Copy link

ROS-243 completed by @AbnerZheng, ROS-197 completed by @AbnerZheng. RHOL-44 and RHOL-45 in flight with @AbnerZheng.

@lapin7
Copy link
Contributor Author

lapin7 commented Jan 28, 2018

@dckc worked on Compiler-Web stuff

@dckc
Copy link
Contributor

dckc commented Jan 28, 2018

@lapin7 let's keep this issue focussed on VM primitives, CI integration and use #185 for Compiler-Web stuff. I created #255 for the example contracts (RHOL-44, RHOL-45).

@AbnerZheng 's work on VM primitives is in scope here:

  • ROS-243: 8 story points; PR121 merged 8 Jan
  • ROS-197: 8 story points; merged Dec 20

Next I'll add numbers in the budget / reward spreadsheet...

@AbnerZheng
Copy link
Contributor

Just a short comment to become a participant on this issue. Aha

@AbnerZheng
Copy link
Contributor

AbnerZheng commented Feb 1, 2018

@lapin7 @dckc @MParlikar
There must be something wrong for the budget and reward for this issue. @dckc vote 640$ for this issue, I guess he must want apply all budget for work done for this month, because if the total budget for this issue is 640$, and then the percentage of my work is 5%, then my reward is 32$. So I vote 25000$ for this budget so that, my reward is about 16*40 = 640$. I don't know tho rate from story point to $, I assume it is 40$/story point.

@dckc
Copy link
Contributor

dckc commented Feb 1, 2018 via email

@MParlikar
Copy link

What needs to be done in order to fix this? @dckc @lapin7 How does the budget roll over from last month?

@dckc
Copy link
Contributor

dckc commented Feb 1, 2018

@MParlikar I'm inclined to see the big spreadsheet as a useful prototype and retire it. See #260 for a next prototype.

@lapin7
Copy link
Contributor Author

lapin7 commented Feb 2, 2018 via email

@AbnerZheng
Copy link
Contributor

@lapin7 The reward for my work is right. Thanks.

@dckc
Copy link
Contributor

dckc commented Feb 2, 2018

@lapin7 in the scope of this ticket, my only contributions in January were coordination, onboarding, and guiding.

My coding work was mostly in #185.

@linsheng9731
Copy link

I have made a PR for ROS-247 and ROS-314. @lapin7 @MParlikar Please assign someone to review it, thank you.
rchain/rchain#218

@lapin7
Copy link
Contributor Author

lapin7 commented Feb 2, 2018 via email

@linsheng9731
Copy link

linsheng9731 commented Feb 17, 2018

After i rebased dev branch, there was something wrong with this pull-request rchain/rchain#218. So i made a new pull-request here. rchain/rchain#296

@dckc
Copy link
Contributor

dckc commented May 7, 2018

Medha is making new issues for more recent contributions to the core development work.

@dckc dckc closed this as completed May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development splitting into core-dev, developer-education, ...? (guides: @dckc, ...)
Projects
None yet
Development

No branches or pull requests

8 participants