Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Zf3 #73

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[WIP] Zf3 #73

wants to merge 8 commits into from

Conversation

raykolbe
Copy link
Owner

@raykolbe raykolbe commented Nov 25, 2017

Change Profile

Question Answer
New feature yes
Bug fix no
BC breaks yes
Passing tests yes

Description

⚠️ Work in progress: Upgrade to support ZF3.

Notable Breaking Changes

  • Namespace changed from DOMPDFModule to DompdfModule.
  • Service name change from DOMPDF to Dompdf.
  • No longer works with ZF2.
  • Moved source files from src/DOMPDFModule to src.
  • Moved Module.php to src/Module.php

Reason

Ensure continued support of ZF framework.

@raykolbe raykolbe added this to the 0.6.0 milestone Nov 25, 2017
@raykolbe raykolbe self-assigned this Nov 25, 2017
'ViewPdfStrategy' => __NAMESPACE__ . '\Mvc\Service\ViewPdfStrategyFactory',
'Dompdf' => Service\DompdfFactory::class,
'ViewPdfRenderer' => Mvc\Service\ViewPdfRendererFactory::class,
'ViewPdfStrategy' => Mvc\Service\ViewPdfRendererFactory::class

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raykolbe This should read Mvc\Service\ViewPdfStrategyFactory::class rather than RendererFactory::class.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@svencan
Copy link

svencan commented May 23, 2018

Any update on this? It would be nice if this was finally usable via composer as 0.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants