Upgrade to ZF3 #57
Upgrade to ZF3 #57
Conversation
|
What is the reason that you require php 7 and test only php 7.1 too? ZF3 has a minimal requirement of php 5.6, so you should create all extensions based on this requirement of 5.6, to keep the environment on an even level. |
| - 5.5 | ||
| - 5.6 | ||
| - 7.0 | ||
| - 7.1 |
There was a problem hiding this comment.
I tried adding PHP version 5.6 but this one giving error because of a doctrine dependency, could help solve?
| "zendframework/zend-http": "^2.1.6", | ||
| "zendframework/zend-console": "^2.1.6", | ||
| "dompdf/dompdf": "^0.6.0" | ||
| "php": "^7.0", |
|
|
||
| class PdfStrategy implements ListenerAggregateInterface | ||
| class PdfStrategy extends AbstractListenerAggregate |
There was a problem hiding this comment.
should still implement \Zend\EventManager\ListenerAggregateInterface
There was a problem hiding this comment.
The AbstractListenerAggregate class already implements the ListenerAggregateInterface interface and it contains the implementation of the detach method in which it was implemented by the ZF community, I do not think it has the need to write the method again knowing that it already exists, I think we should reuse it.
https://github.com/zendframework/zend-eventmanager/blob/master/src/AbstractListenerAggregate.php
Update to work on ZF3.
Updates have been made on all packages and on the version of PHP 5.6 or 7.0
I have not yet tested the configuration file, if there is anyone who can help I'll be grateful.