Adding NeMo Curator #382
Closed
Adding NeMo Curator #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
requested changes
Jun 6, 2024
assets/scss/rapidsai/__general.scss
Outdated
| cursor: pointer; | ||
| text-decoration: none; |
There was a problem hiding this comment.
This is defining text-decoration twice.
Suggested change
| text-decoration: none; |
go.sum
Outdated
| @@ -1,4 +1,8 @@ | |||
| github.com/FortAwesome/Font-Awesome v0.0.0-20230327165841-0698449d50f2/go.mod h1:IUgezN/MFpCDIlFezw3L8j83oeiIuYoj28Miwr/KUYo= | |||
| github.com/FortAwesome/Font-Awesome v0.0.0-20240402185447-c0f460dca7f7/go.mod h1:IUgezN/MFpCDIlFezw3L8j83oeiIuYoj28Miwr/KUYo= | |||
There was a problem hiding this comment.
Why does this have checksums for multiple versions? If we updated a dependency, we do not need to keep the old checksums for versions we no longer depend on. Is this automatically generated? Maybe delete it and regenerate it?
package-lock.json
Outdated
| @@ -1,12 +1,12 @@ | |||
| { | |||
| "name": "rapids.ai", | |||
| "name": "rapids.ai_ae", | |||
There was a problem hiding this comment.
I have multiple copies of RAPIDS repo from different forks.
Yeah not sure what happened - I think Ill rebase and try again next change I have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding NeMo curator section per #376 request. Thanks for your patience.
Some other minor content fixes.