Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NeMo Curator Section #385

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Added NeMo Curator Section #385

merged 3 commits into from
Jun 25, 2024

Conversation

exactlyallan
Copy link
Member

Adding per #382 request. Trying PR again without conflicts.

@exactlyallan exactlyallan added the 3 - Ready for Review Ready for review by team label Jun 18, 2024
@exactlyallan exactlyallan requested a review from a team as a code owner June 18, 2024 21:36
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed one small fix for the spacing of the Clara section, and changed MONAI to all caps (that's how they write it). Otherwise this looks good.

class="fa-solid fa-tag"></i> NVIDIA AI </span>
class="fa-solid fa-tag"></i> PYTHON </span>
<span class="tags-item text-rapids-purple-primary border-rapids-purple-primary"><i
class="fa-solid fa-tag"></i> NEMO </span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do these tags really mean? We only have one tag for "NEMO". Would it be better to have the tag "NVIDIA AI"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are more closely aligned with NeMo projects vs NVAIE

@exactlyallan exactlyallan merged commit 80eef41 into rapidsai:main Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants