Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NumPy <2 pin #718

Merged
merged 11 commits into from
Sep 30, 2024
Merged

Remove NumPy <2 pin #718

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7f68313
Remove NumPy <2 pin.
seberg Aug 19, 2024
93723f0
Include pre-release identifier for upper pin
seberg Aug 20, 2024
3d4db70
Merge branch 'branch-24.10' into my_new_branch
jameslamb Sep 18, 2024
d9c596f
Update conda/recipes/versions.yaml
jameslamb Sep 18, 2024
e632aad
Merge branch 'branch-24.10' into my_new_branch
jameslamb Sep 24, 2024
e337462
try skipping cuxfilter and cugraph
jameslamb Sep 24, 2024
ffa5243
Merge branch 'branch-24.10' into my_new_branch
jameslamb Sep 24, 2024
b7604c8
Merge branch 'branch-24.10' into my_new_branch
jameslamb Sep 30, 2024
691d5e8
remove testing-only changes
jameslamb Sep 30, 2024
0a66fe1
Merge branch 'my_new_branch' of github.com:seberg/integration into my…
jameslamb Sep 30, 2024
73d7214
Update conda/recipes/versions.yaml
jameslamb Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conda/recipes/versions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ nccl_version:
numba_version:
- '>=0.57'
numpy_version:
- '>=1.23,<2.0a0'
- '>=1.23,<3.0a0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- '>=1.23,<3.0a0'
#- '>=1.23,<3.0a0'
- '>=2,<3.0a0'

@msarahan I just updated this PR, gonna try a build with this pin to see what we can learn from the solver errors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most builds there failed in uninformative ways.

I've just pushed another set of commits that does the following:

Hoping we can use that to confirm that only cuxfilter and cugraph remain for RAPIDS to be installable alongside NumPy 2.x.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 that worked!

...
    numpy:                            2.0.2-py311h71ddf71_0                            conda-forge 
...

(build link)

I think we can now say with confidence: getting cuxfilter and cugraph supporting NumPy 2 will allow RAPIDS to support NumPy 2 😁

(cc @jakirkham @seberg for awareness)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuxfilter was merged yesterday: rapidsai/cuxfilter#622

So just cugraph remains: rapidsai/cugraph#4615

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged rapidsai/cugraph#4615. Will update this again once nightly packages are built from it.

Build to watch:

https://github.com/rapidsai/cugraph/actions/runs/11107406693/job/30857924045

nvtx_version:
- '>=0.2.1,<0.3'
ucx_version:
Expand Down