-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NumPy <2 pin #718
Remove NumPy <2 pin #718
Conversation
NOTE: this one shouldn't be considered done until we see a solve with NumPy In the latest build (run a few weeks ago), some dependencies in the environment led to
Adding |
This is for testing purposes. Once this PR is passing, it is safe to merge rapidsai#718, which allows numpy range from >=1.23,<3.0a0
@@ -11,7 +11,7 @@ nccl_version: | |||
numba_version: | |||
- '>=0.57' | |||
numpy_version: | |||
- '>=1.23,<2.0a0' | |||
- '>=1.23,<3.0a0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- '>=1.23,<3.0a0' | |
#- '>=1.23,<3.0a0' | |
- '>=2,<3.0a0' |
@msarahan I just updated this PR, gonna try a build with this pin to see what we can learn from the solver errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most builds there failed in uninformative ways.
I've just pushed another set of commits that does the following:
- updates to latest
branch-24.10
, to get thefmt
/spdlog
updates from remove pins on geospatial libraries, RAPIDS nightlies #722 - commented out
cuxfiter
and*cugraph*
packages
Hoping we can use that to confirm that only cuxfilter
and cugraph
remain for RAPIDS to be installable alongside NumPy 2.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 that worked!
...
numpy: 2.0.2-py311h71ddf71_0 conda-forge
...
I think we can now say with confidence: getting cuxfilter
and cugraph
supporting NumPy 2 will allow RAPIDS to support NumPy 2 😁
(cc @jakirkham @seberg for awareness)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cuxfilter
was merged yesterday: rapidsai/cuxfilter#622
So just cugraph
remains: rapidsai/cugraph#4615
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just merged rapidsai/cugraph#4615. Will update this again once nightly packages are built from it.
Build to watch:
https://github.com/rapidsai/cugraph/actions/runs/11107406693/job/30857924045
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks James! 🙏
/merge |
This PR removes the NumPy<2 pin which is expected to work for
RAPIDS projects once CuPy 13.3.0 is released (CuPy 13.2.0 had
some issues preventing the use with NumPy 2).