Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NumPy <2 pin #718

Merged
merged 11 commits into from
Sep 30, 2024
Merged

Remove NumPy <2 pin #718

merged 11 commits into from
Sep 30, 2024

Conversation

seberg
Copy link
Contributor

@seberg seberg commented Aug 19, 2024

This PR removes the NumPy<2 pin which is expected to work for
RAPIDS projects once CuPy 13.3.0 is released (CuPy 13.2.0 had
some issues preventing the use with NumPy 2).

@jameslamb
Copy link
Member

NOTE: this one shouldn't be considered done until we see a solve with NumPy >= 2 in it.

In the latest build (run a few weeks ago), some dependencies in the environment led to numpy==1.26.4 getting pulled in:

    numpy:                            1.26.4-py311h69ead2a_0                           conda-forge   

(build link)

Adding test:-section pins of the form numpy>=2 in the conda recipes might help expose this in CI.

@msarahan msarahan self-assigned this Sep 18, 2024
msarahan added a commit to msarahan/integration that referenced this pull request Sep 18, 2024
This is for testing purposes. Once this PR is passing, it is safe to merge rapidsai#718, which allows numpy range from >=1.23,<3.0a0
@@ -11,7 +11,7 @@ nccl_version:
numba_version:
- '>=0.57'
numpy_version:
- '>=1.23,<2.0a0'
- '>=1.23,<3.0a0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- '>=1.23,<3.0a0'
#- '>=1.23,<3.0a0'
- '>=2,<3.0a0'

@msarahan I just updated this PR, gonna try a build with this pin to see what we can learn from the solver errors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most builds there failed in uninformative ways.

I've just pushed another set of commits that does the following:

Hoping we can use that to confirm that only cuxfilter and cugraph remain for RAPIDS to be installable alongside NumPy 2.x.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 that worked!

...
    numpy:                            2.0.2-py311h71ddf71_0                            conda-forge 
...

(build link)

I think we can now say with confidence: getting cuxfilter and cugraph supporting NumPy 2 will allow RAPIDS to support NumPy 2 😁

(cc @jakirkham @seberg for awareness)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuxfilter was merged yesterday: rapidsai/cuxfilter#622

So just cugraph remains: rapidsai/cugraph#4615

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged rapidsai/cugraph#4615. Will update this again once nightly packages are built from it.

Build to watch:

https://github.com/rapidsai/cugraph/actions/runs/11107406693/job/30857924045

@jameslamb jameslamb marked this pull request as ready for review September 30, 2024 15:55
@jameslamb jameslamb requested a review from a team as a code owner September 30, 2024 15:55
@jameslamb jameslamb requested review from raydouglass and removed request for raydouglass September 30, 2024 15:55
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James! 🙏

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit fb695dd into rapidsai:branch-24.10 Sep 30, 2024
28 checks passed
@seberg seberg deleted the my_new_branch branch September 30, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants