Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop CentOS 7 support. #15323

Merged
merged 7 commits into from
Mar 20, 2024
Merged

Drop CentOS 7 support. #15323

merged 7 commits into from
Mar 20, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 15, 2024 •
edited
Loading

Description

This PR tests rapidsai/shared-workflows#192, which drops CentOS 7 support. See rapidsai/build-planning#23.

This PR removes the logic needed to build and test both manylinux_2_17 and manylinux_2_28 wheels, as we will only be building for manylinux_2_28.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice added 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 15, 2024
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue conda Java Affects Java cuDF API. and removed improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 15, 2024
@bdice bdice mentioned this pull request Mar 15, 2024
Closed
24 tasks
@bdice bdice changed the base branch from branch-24.04 to branch-24.06 March 15, 2024 23:11
@github-actions github-actions bot added ci and removed Python Affects Python cuDF API. conda Java Affects Java cuDF API. labels Mar 16, 2024
@bdice bdice marked this pull request as ready for review March 18, 2024 20:21
@bdice bdice requested review from a team as code owners March 18, 2024 20:21
@bdice bdice removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Mar 19, 2024
@bdice bdice self-assigned this Mar 19, 2024
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 19, 2024
@bdice bdice mentioned this pull request Mar 19, 2024
Merged
vyasr
vyasr approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These simplifications all look good, all wheels are implicitly 2.28 wheels now.

@bdice
Copy link
Contributor Author

bdice commented Mar 20, 2024

/merge

@rapids-bot rapids-bot bot merged commit ae16ecb into rapidsai:branch-24.06 Mar 20, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@vyasr vyasr vyasr approved these changes

Assignees

@bdice bdice

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @vyasr @AyodeAwe