Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove input for build-2_28-wheels. #195

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Remove input for build-2_28-wheels. #195

merged 1 commit into from
Mar 20, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 19, 2024

Cleans up an extra option that was needed to support building both manylinux_2_28 and manylinux_2_17 wheels for cudf.

Depends on rapidsai/cudf#15323.

@bdice bdice changed the base branch from branch-24.04 to branch-24.06 March 19, 2024 16:26
@bdice
Copy link
Contributor Author

bdice commented Mar 19, 2024 •
edited
Loading

This should not be merged until rapidsai/cudf#15323 goes into cudf. That's the only reference to this option in RAPIDS.

@bdice bdice mentioned this pull request Mar 19, 2024
Closed
24 tasks
@jameslamb jameslamb self-requested a review March 19, 2024 16:38
jameslamb
jameslamb approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me based on the linked issue and #192. I'm glad to see this workflow getting simplified.

vyasr
vyasr approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess at this point the var is already a no-op after #192 so it's just workflow cleanup that can happen once the variable is not in use.

@bdice bdice merged commit 60d8f1c into branch-24.06 Mar 20, 2024
@ajschmidt8 ajschmidt8 deleted the remove-build-2_28-wheels branch November 5, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @vyasr @jameslamb