Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-23.08 to branch-23.10 #13730

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Commits on Jul 21, 2023

  1. Remove the erroneous "empty level" short-circuit from ORC reader (#13722

    )
    
    Closes #13709
    
    ORC reader skips some decode steps in the corner case where a column hierarchy level contains no data (e.g. struct with no validity mask).
    However, some of the skipped steps might still be required; for example, null masks need to the propagated to the child columns.
    
    This PR removes the short-circuit in the corner case, allowing correct decode when null masks need to be propagated.
    This PR also moves creation of the time zone table out of the level-by-level loop, as it can just be reused at all levels.
    
    Authors:
      - Vukasin Milovanovic (https://github.com/vuule)
    
    Approvers:
      - Bradley Dice (https://github.com/bdice)
      - Divye Gala (https://github.com/divyegala)
    
    URL: #13722
    vuule authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    e0fa34b View commit details
    Browse the repository at this point in the history