Forward-merge branch-23.08 to branch-23.10 #13730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Closes #13709 ORC reader skips some decode steps in the corner case where a column hierarchy level contains no data (e.g. struct with no validity mask). However, some of the skipped steps might still be required; for example, null masks need to the propagated to the child columns. This PR removes the short-circuit in the corner case, allowing correct decode when null masks need to be propagated. This PR also moves creation of the time zone table out of the level-by-level loop, as it can just be reused at all levels. Authors: - Vukasin Milovanovic (https://github.com/vuule) Approvers: - Bradley Dice (https://github.com/bdice) - Divye Gala (https://github.com/divyegala) URL: #13722
GPUtester
requested review from
vyasr,
galipremsagar and
nvdbaranec
and removed request for
a team
|
SUCCESS - forward-merge complete. |
github-actions
bot
added
libcudf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to
branch-23.08that creates a PR to keepbranch-23.10up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.