test: add e2e for rancher with embedded capi disabled #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
added
kind/enhancement
richardcase
reviewed
Oct 17, 2023
richardcase
reviewed
Oct 17, 2023
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
test-installing-rancher-with-embedded-capi-disabled
branch
from
348705c
to
7d3ef02
Compare
|
I rebased the changes and updated the new test suit based on #204. |
richardcase
approved these changes
Oct 17, 2023
|
What is the issue with |
|
@Danil-Grigorev the issue occurs when installing Rancher first with the feature disabled (this was reported some time ago here). It does not fail when installing Rancher Turtles before Rancher, which is the case for the update-labels test suite. |
alexander-demicev
approved these changes
Oct 18, 2023
Danil-Grigorev
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With #190 we are changing the tests so that Rancher is installed first with the "embedded CAPI" feature flag enabled and then disabling it before installing Rancher Turtles. This PR adds a new E2E test scenario that covers the installation in reversed order: we install Rancher first with
embedded-cluster-apidisabled and then install Rancher Turtles.Which issue(s) this PR fixes:
Fixes #193
Special notes for your reviewer:
QA reported rancher/rancher#41724 a few months ago, describing a problem encountered when installing Rancher with the embedded CAPI feature flag set to false. After some investigation (mainly trial & error), it looks like using the format
--set features=embedded-cluster-api=falsedoes not work and Rancher ultimately fails to install. From our own development environment setup here, we get the format--set CATTLE_FEATURES=embedded-cluster-api=falsewhich seems to be fixing this issue. This is now changed inrancher.go.Apart from the environment setup, the tests are equivalent to those used in
suites/v2prov. Hopefully this aligns with what's expected.This PR needs to be rebased and updated after merging #204✅Checklist: