chore(deps) : upgrade to postgres 16.3-alpine #1226
Conversation
|
Warning Rate Limit Exceeded@rajadilipkolli has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 27 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe updates across various test configurations in multiple projects involve upgrading the PostgreSQL Docker image version from older versions (such as "16.2-alpine" or "16.1-alpine") to "16.3-alpine". This change is consistent across files, enhancing consistency and possibly incorporating improvements or bug fixes from the newer PostgreSQL version. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
component: jobrunr
component: graphql-webflux
component : choas-monkey
component: data-envers
component: jpa-multitenancy
component : archunit
component: multiple-datasources
component: graphql-querydsl
component: graphql-webmvc
component: r2dbc
component : spring-batch
component: rest-docs
component: keyset-pagination
component: jpa-lock
component: quartz
component: shedlock
labels
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (21)
- batch-boot-jpa-sample/src/test/java/com/example/bootbatchjpa/common/TestContainersConfig.java (1 hunks)
- boot-api-archunit-sample/src/test/java/com/example/archunit/common/ContainersConfig.java (1 hunks)
- boot-choas-monkey/src/test/java/com/example/choasmonkey/TestApplication.java (2 hunks)
- boot-rest-docs-sample/src/test/java/com/example/restdocs/TestApplication.java (1 hunks)
- graphql/boot-graphql-querydsl/src/test/java/com/example/graphql/querydsl/common/ContainersConfig.java (1 hunks)
- graphql/boot-graphql-webflux/src/test/java/com/example/graphql/TestApplication.java (1 hunks)
- graphql/boot-graphql-webmvc/src/test/java/com/example/graphql/common/TestContainersConfig.java (1 hunks)
- jpa/boot-data-envers/src/test/java/com/example/envers/common/ContainersConfig.java (1 hunks)
- jpa/boot-data-keyset-pagination/src/test/java/com/example/keysetpagination/common/ContainersConfig.java (1 hunks)
- jpa/boot-data-multipledatasources/src/test/java/com/example/multipledatasources/ApplicationIntegrationTest.java (2 hunks)
- jpa/boot-jpa-locks/src/test/java/com/example/locks/common/ContainersConfig.java (1 hunks)
- jpa/multitenancy/multidatasource-multitenancy/src/test/java/com/example/multitenancy/common/DBContainerInitializer.java (1 hunks)
- jpa/multitenancy/multitenancy-db/src/test/java/com/example/multitenancy/db/common/DBContainerInitializer.java (1 hunks)
- jpa/multitenancy/partition/src/test/java/com/example/multitenancy/partition/common/DBContainerInitializer.java (1 hunks)
- jpa/multitenancy/schema/src/test/java/com/example/multitenancy/schema/config/TestContainersConfiguration.java (2 hunks)
- r2dbc/boot-jooq-r2dbc-sample/src/test/java/com/example/jooq/r2dbc/TestApplication.java (2 hunks)
- r2dbc/boot-r2dbc-sample/src/test/java/com/example/bootr2dbc/TestApplication.java (1 hunks)
- scheduler/boot-jobrunr-sample/src/test/java/com/example/jobrunr/TestApplication.java (1 hunks)
- scheduler/boot-scheduler-quartz/src/test/java/com/scheduler/quartz/common/ContainersConfig.java (1 hunks)
- scheduler/boot-shedlock-sample/src/test/java/com/learning/shedlock/SchemaValidationTest.java (1 hunks)
- scheduler/boot-shedlock-sample/src/test/java/com/learning/shedlock/common/ContainersConfig.java (1 hunks)
Files skipped from review due to trivial changes (6)
- batch-boot-jpa-sample/src/test/java/com/example/bootbatchjpa/common/TestContainersConfig.java
- boot-api-archunit-sample/src/test/java/com/example/archunit/common/ContainersConfig.java
- jpa/boot-data-keyset-pagination/src/test/java/com/example/keysetpagination/common/ContainersConfig.java
- jpa/boot-jpa-locks/src/test/java/com/example/locks/common/ContainersConfig.java
- jpa/multitenancy/multidatasource-multitenancy/src/test/java/com/example/multitenancy/common/DBContainerInitializer.java
- scheduler/boot-shedlock-sample/src/test/java/com/learning/shedlock/SchemaValidationTest.java
Additional comments not posted (26)
graphql/boot-graphql-webmvc/src/test/java/com/example/graphql/common/TestContainersConfig.java (1)
10-11: Update to PostgreSQL 16.3-alpine using DockerImageName.parse() is correctly implemented.jpa/boot-data-envers/src/test/java/com/example/envers/common/ContainersConfig.java (1)
15-15: Update to PostgreSQL 16.3-alpine using DockerImageName.parse() is correctly implemented.scheduler/boot-scheduler-quartz/src/test/java/com/scheduler/quartz/common/ContainersConfig.java (1)
15-15: Update to PostgreSQL 16.3-alpine using DockerImageName.parse() is correctly implemented.scheduler/boot-shedlock-sample/src/test/java/com/learning/shedlock/common/ContainersConfig.java (1)
15-15: Update to PostgreSQL 16.3-alpine using DockerImageName.parse() is correctly implemented.graphql/boot-graphql-querydsl/src/test/java/com/example/graphql/querydsl/common/ContainersConfig.java (1)
15-15: Update to PostgreSQL 16.3-alpine using DockerImageName.parse() with container reuse enabled is correctly implemented, enhancing test performance.jpa/multitenancy/schema/src/test/java/com/example/multitenancy/schema/config/TestContainersConfiguration.java (1)
17-17: Update to PostgreSQL 16.3-alpine using DockerImageName.parse() is correctly implemented. Please verify the intended use ofRestartScopein this context to ensure it aligns with your testing strategy.Verification successful
The usage of
@RestartScopeis consistent across multiple test configurations in different modules of the repository. This widespread application suggests that it is part of a deliberate testing strategy, likely involving scenarios where application restarts are simulated or required. The initial implementation in theTestContainersConfiguration.javafile aligns with this broader usage pattern.
- Files using
@RestartScope:
jpa/multitenancy/schema/src/test/java/com/example/multitenancy/schema/config/TestContainersConfiguration.javahttpClients/boot-http-proxy/src/test/java/com/example/rest/proxy/TestApplication.javaboot-togglz-sample/src/test/java/com/example/featuretoggle/TestApplication.javaboot-rabbitmq-thymeleaf/src/test/java/com/poc/boot/rabbitmq/TestRabbitMQApplication.javaboot-mongodb-elasticsearch/src/test/java/com/example/mongoes/TestApplication.java(used twice)boot-choas-monkey/src/test/java/com/example/choasmonkey/TestApplication.javaScripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `RestartScope` in test configurations. # Test: Search for the usage of `RestartScope` in test configurations. Expect: Justified use cases or explanations. rg --type java '@RestartScope'Length of output: 762
graphql/boot-graphql-webflux/src/test/java/com/example/graphql/TestApplication.java (1)
16-16: Update to PostgreSQL 16.3-alpine using DockerImageName.parse() is correctly implemented.scheduler/boot-jobrunr-sample/src/test/java/com/example/jobrunr/TestApplication.java (1)
16-16: Update to PostgreSQL 16.3-alpine using DockerImageName.parse() is correctly implemented.boot-rest-docs-sample/src/test/java/com/example/restdocs/TestApplication.java (2)
8-8: Import statement forDockerImageNameis correctly added to support the new container instantiation method.
16-16: Updated PostgreSQLContainer instantiation usingDockerImageName.parse()enhances robustness in handling Docker image names.r2dbc/boot-r2dbc-sample/src/test/java/com/example/bootr2dbc/TestApplication.java (2)
8-8: Import statement forDockerImageNameis correctly added to support the new container instantiation method.
16-16: Updated PostgreSQLContainer instantiation usingDockerImageName.parse()enhances robustness in handling Docker image names.boot-choas-monkey/src/test/java/com/example/choasmonkey/TestApplication.java (3)
18-18: Addition of@RestartScopeis appropriate for development environments with frequent live reloads.
9-9: Import statement forDockerImageNameis correctly added to support the new container instantiation method.
18-18: Updated PostgreSQLContainer instantiation usingDockerImageName.parse()enhances robustness in handling Docker image names.r2dbc/boot-jooq-r2dbc-sample/src/test/java/com/example/jooq/r2dbc/TestApplication.java (3)
17-17: Addition ofwithCopyFileToContainerfor SQL script initialization enhances the setup process for database testing.
8-8: Import statement forDockerImageNameis correctly added to support the new container instantiation method.
17-17: Updated PostgreSQLContainer instantiation usingDockerImageName.parse()enhances robustness in handling Docker image names.jpa/multitenancy/partition/src/test/java/com/example/multitenancy/partition/common/DBContainerInitializer.java (3)
13-13: Setting database name, username, and password directly in the container instantiation is secure and encapsulated.
7-7: Import statement forDockerImageNameis correctly added to support the new container instantiation method.
13-13: Updated PostgreSQLContainer instantiation usingDockerImageName.parse()enhances robustness in handling Docker image names.jpa/multitenancy/multitenancy-db/src/test/java/com/example/multitenancy/db/common/DBContainerInitializer.java (3)
15-15: UsingStartables.deepStartto start multiple containers concurrently optimizes the startup time of test environments.
9-9: Import statement forDockerImageNameis correctly added to support the new container instantiation method.
15-15: Updated PostgreSQLContainer instantiation usingDockerImageName.parse()enhances robustness in handling Docker image names.jpa/boot-data-multipledatasources/src/test/java/com/example/multipledatasources/ApplicationIntegrationTest.java (2)
32-32: Instantiating PostgreSQLContainer withDockerImageName.parse()in a test class using multiple data sources ensures correct database configuration for integration testing.
20-20: Import statement forDockerImageNameis correctly added to support the new container instantiation method.
github-actions
bot
added
the
type: dependency-upgrade
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- jpa/multitenancy/partition/pom.xml (2 hunks)
- jpa/multitenancy/partition/src/test/java/com/example/multitenancy/partition/TestApplication.java (1 hunks)
- jpa/multitenancy/partition/src/test/java/com/example/multitenancy/partition/common/AbstractIntegrationTest.java (1 hunks)
Files skipped from review due to trivial changes (2)
- jpa/multitenancy/partition/pom.xml
- jpa/multitenancy/partition/src/test/java/com/example/multitenancy/partition/common/AbstractIntegrationTest.java
Additional comments not posted (2)
jpa/multitenancy/partition/src/test/java/com/example/multitenancy/partition/TestApplication.java (2)
13-17: Update to PostgreSQL 16.3-alpine is correctly implemented usingDockerImageName.parse().
19-21: The main method correctly configures the application to run withTestApplicationclass.
|
Summary by CodeRabbit
DockerImageName.parsemethod for better clarity and maintainability in code.