Add Franka Simulation package to SERL #1
Conversation
There was a problem hiding this comment.
Thanks for the PR, i briefly tried to run it. Manage to run the frank_sim env.
high level feedback, it would be great to install all packages directly from the level-0 serl directory, instead needing to go in the individual readme.
Maybe something like this:
find . -name 'requirements.txt' -execdir pip3 install -r {} \;
find . -name 'setup.py' -execdir pip3 install -e . \;
# run the env
python franka_sim/franka_sim/test/test_gym_env_human.py
README.md
Outdated
|
|
||
| ## Installation | ||
| - Conda Environment: | ||
| - create an environment with `conda create -n serl_dev python=3.10` |
There was a problem hiding this comment.
Ok, just fixed this.
There was a problem hiding this comment.
For the requirements.txt, are you thinking about putting all the package dependencies into one requirements.txt? Originally, I was thinking about having a requirement_sim.txt so users can optionally choose if they want to try sim.
There was a problem hiding this comment.
Oh I mean that the "coverpage" readme should cover the instructions on how to run and install the code, without needing the user to find it. So just a short code snippet of how to install it will do. The above code snippet is just a cli to install all underlying pkgs in the repo.
In this case that the sim is optional, we can add it soon.
Signed-off-by: youliangtan <[email protected]>
good catch, lets do that
This PR includes a simple Franka lift cube Gym environment and its assets. Installation and testing instructions are in the README.md.
Thank you for reviewing!