Record invite confirmed state #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the is_invite_confirmed field to members and update it to true when a member is trusted by the member they requested an invite from.
tinaroh
approved these changes
Jun 22, 2018
src/routes/members/index.ts
Outdated
| } | ||
| if ( | ||
| !(await operationsCollection | ||
| .where("creator_uid", "==", loggedInUid) |
There was a problem hiding this comment.
make this part of the transaction too
osdiab
approved these changes
Jun 22, 2018
osdiab
reviewed
Jun 22, 2018
| @@ -97,7 +97,7 @@ const apiRoutes: Array<RouteHandler<ApiLocation>> = [ | |||
| }, | |||
| { | |||
| location: trustMemberApiLocation, | |||
| handler: membersRoutes.trust(membersCollection, operationsCollection) | |||
| handler: membersRoutes.trust(db, membersCollection, operationsCollection) | |||
There was a problem hiding this comment.
Hmm, maybe we should just make getting the membersCollection and operationsCollection a function that takes in db, since these are sorta redundant
There was a problem hiding this comment.
Makes sense, created #51 to track.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the is_invite_confirmed field to members and update it to true when
a member is trusted by the member they requested an invite from.