Migration to add invite confirmed field. #21
Conversation
| inviteOps.length | ||
| ); | ||
| continue; | ||
| } else if (inviteOps.length > 1) { |
There was a problem hiding this comment.
Are we just skipping these? why?
There was a problem hiding this comment.
Ah, these inviteOps checks were just to see if anybody had requested an invite multiple times. Nobody has, so I can just remove this block altogether.
There was a problem hiding this comment.
Actually, jk, I can't remove it since the "RAHA" user has never requested an invite and should be skipped for now. No one's requested multiple invites though.
| invite_confirmed: true | ||
| }); | ||
| } else if (requestInviteFromMemberId !== inviteOpData.to_uid) { | ||
| console.log( |
There was a problem hiding this comment.
Does this happen? what do we do with those?
There was a problem hiding this comment.
It did.. I fixed them manually since they were all clearly errors from our more manual days.
|
Also does this mean that we are now keeping track of both trust operations and invite_confirmed field? How do we ensure they're consistent with one another? |
|
The recently landed change to api (rahafoundation/raha-api#49) ensures that the members collection stays up to date after this migration. That PR is generally with the goal of moving closer to a world where we can rely on the members collection to reflect the current state of the world and no longer have to re-create it each time we load the app. |
rahulgi
force-pushed
the
rg-migration-add-is-invite-confirmed-field
branch
from
3c8f693 to
c8f0087
Compare
rahulgi
changed the base branch from
rg-migration-standardize-request-invite-from-uid-fieldname
to
master
rahulgi
force-pushed
the
rg-migration-add-is-invite-confirmed-field
branch
from
c8f0087 to
56c77f9
Compare
No description provided.