Astropy 6.1.4 #17096 regression fix #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also fixes our use of |
keflavich
reviewed
Oct 1, 2024
keflavich
approved these changes
Oct 1, 2024
e-koch
commented
Oct 1, 2024
mhvk
reviewed
Oct 1, 2024
|
@keflavich ready to merge after tests pass. |
Closed
|
@keflavich Looks like spectral-cube's test failures are also related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From astropy/astropy#17096: astropy 6.1.4 introduced a bug here due to our use of
when
pais aQuantityandpa=0 * u.deg. The immediate fix is to compare to the unit, not the quantity. (See traceback from @olebole here astropy/astropy#17096 (comment)).