-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small issues with Beam #127
Comments
Thanks @mhvk ! I opened #128 to fix the specific issue in astropy/astropy#17096, and the agreed, we should look into switching to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As I was looking at the
beam
code for astropy/astropy#17096, I noticed a few oddities inBeam
. Mostly that it inherits fromQuantity
, which I'm not sure is a good idea given that some basic methods are overwritten and many others would not work (e.g., you'd need a proper__array_finalize__
to deal with slicing, etc.; right now, you'd lose the extra attributes with you dobeam[()]
). If there are real advantages to usingBeam
, I'd recommend usingSpecificTypeQuantity
.A second thing I happened to notice is that
default_unit
is not actually used as described in the docstring.Anyway, just flyby comments - hopefully of some use.
The text was updated successfully, but these errors were encountered: