Catch 'else { if' where 'else if' is preferable in unnecessary_nesting_linter() #2462
Conversation
|
Sorry, too fast for GH to change target again... |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2462 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 126 126
Lines 5712 5720 +8
=======================================
+ Hits 5629 5637 +8
Misses 83 83 ☔ View full report in Codecov by Sentry. |
| @@ -34,6 +34,7 @@ rx_static_token <- local({ | |||
| rx_unescaped_regex <- paste0("(?s)", rex(start, zero_or_more(rx_non_active_char), end)) | |||
| rx_static_regex <- paste0("(?s)", rex(start, zero_or_more(rx_static_token), end)) | |||
| rx_first_static_token <- paste0("(?s)", rex(start, zero_or_more(rx_non_active_char), rx_static_escape)) | |||
| rx_escapable_tokens <- "^${}().*+?|[]\\<>=:;/_-!@#%&,~" | |||
There was a problem hiding this comment.
How did this diff get in here?
There was a problem hiding this comment.
This is newly linted:
Lines 105 to 111 in 72eeefd
I was originally going to move the comment to the end of the line, so pulled out this constant to keep things within 120. In the end opted to move the comment as shown.
Kept this change because I still think it's better -- abstracts away the logic for readability.
Closes #2317