Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New allow_functions= to control skipped functions in unnecessary_nesting_linter() #2463

Merged
merged 18 commits into from
Mar 1, 2024
Merged

New allow_functions= to control skipped functions in unnecessary_nesting_linter() #2463

merged 18 commits into from
Mar 1, 2024

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Dec 19, 2023 •
edited
Loading

Closes #2334.

Base automatically changed from uni-else to main December 19, 2023 06:47
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (2946bea) to head (54b3c25).

❗ Current head 54b3c25 differs from pull request most recent head 523101d. Consider uploading reports for the commit 523101d to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2463   +/-   ##
=======================================
  Coverage   98.17%   98.18%           
=======================================
  Files         125      125           
  Lines        5714     5715    +1     
=======================================
+ Hits         5610     5611    +1     
  Misses        104      104

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AshesITR
AshesITR reviewed Dec 19, 2023
View reviewed changes
NEWS.md Show resolved Hide resolved
@MichaelChirico
Copy link
Collaborator Author

Bump for review :)

@MichaelChirico MichaelChirico merged commit 106dfb4 into main Mar 1, 2024
20 checks passed
@MichaelChirico MichaelChirico deleted the uni-allow branch March 1, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshesITR AshesITR AshesITR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip switch() and other calls by default in unnecessary_nesting_linter()
3 participants
@MichaelChirico @codecov-commenter @AshesITR