Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Travis, Jenkins, and Werker CI tools posting GitHub comments #2446

Merged
merged 30 commits into from
Feb 29, 2024

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented Dec 15, 2023

Closes #2148

(see comment history for an earlier implementation using {httr2}, but that's removed entirely now)

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (d7c4c5b) to head (75a8eeb).

❗ Current head 75a8eeb differs from pull request most recent head bf9a995. Consider uploading reports for the commit bf9a995 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2446      +/-   ##
==========================================
- Coverage   98.55%   98.17%   -0.38%     
==========================================
  Files         126      125       -1     
  Lines        5762     5714      -48     
==========================================
- Hits         5679     5610      -69     
- Misses         83      104      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AshesITR

This comment was marked as outdated.

R/comments.R Outdated Show resolved Hide resolved
@MichaelChirico

This comment was marked as outdated.

@MichaelChirico

This comment was marked as outdated.

@hadley

This comment was marked as outdated.

@MichaelChirico
Copy link
Collaborator Author

OK looked more carefully. Why we don't get the bot is that we have GHA set up -- we'd need to turn off GHA and on Travis/Wercker/Jenkins to test it out:

lintr/R/methods.R

Lines 95 to 108 in 4b59aac

} else if (in_github_actions()) {
github_actions_log_lints(x, project_dir = github_annotation_project_dir)
} else {
if (in_ci() && settings$comment_bot) {
info <- ci_build_info()
lint_output <- trim_output(
paste0(
collapse = "\n",
capture.output(invisible(lapply(x, markdown, info, ...)))
)
)
github_comment(lint_output, info, ...)

lintr/R/comments.R

Lines 1 to 3 in 4b59aac

in_ci <- function() {
in_travis() || in_wercker() || in_jenkins()
}

We haven't gotten any bugs about the current setup not working... I see {pander} using .lintr with Travis... @daroczig are you aware if .lintr is still posting comments as expected for you?

@daroczig

This comment was marked as outdated.

@MichaelChirico
Copy link
Collaborator Author

MichaelChirico commented Dec 18, 2023

I'm trying to tinker around with Travis a bit on my fork (there are some free credits after providing a credit card):

MichaelChirico#1

In the process, I see that R is only running v4.0.2 and is specifically no longer maintained:

https://travis-ci.community/t/latest-r-version-installation-outdated/13258/3

So I think we should drop Travis support at least.

That just leave Wercker. I don't know anything about it, and we haven't gotten any issues/comments related to it in going on 4 years. I'm tempted to drop support as well unless we get a user request.

cc @krlmlr @cpsievert, I see you own some wercker.yml files mentioning lintr -- any opposition to dropping Wercker support? https://github.com/search?q=path%3Awercker.yml+lintr&type=code

Looking more closely, I see it's all apparently tied back to makeR? which is archived. So I'm assuming "no" for now.

@MichaelChirico MichaelChirico changed the title Migrate to httr2 Drop support for Travis, Jenkins, and Werker CI tools posting GitHub comments Dec 18, 2023
@MichaelChirico
Copy link
Collaborator Author

Test failure seems unrelated but it's persistent, hmm wonder what's going on.

@MichaelChirico
Copy link
Collaborator Author

OK I give up. Genuinely no idea what's going on. Skipping it.

@MichaelChirico
Copy link
Collaborator Author

Bump for review :)

@MichaelChirico
Copy link
Collaborator Author

Friendly bump for review :)

@MichaelChirico MichaelChirico merged commit 8392c0b into main Feb 29, 2024
20 checks passed
@MichaelChirico MichaelChirico deleted the httr-httr2 branch February 29, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use {httr2}, not {httr}
6 participants