New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`in_ci()` doesn't include `in_github_actions()` #1233

Closed

AshesITR opened this issue May 25, 2022 · 3 comments

Labels

automation 🤖

Collaborator

AshesITR commented May 25, 2022

GHA is also a CI, no?

Member

hadley commented May 25, 2022

You can also check that the CI env var is set; that's common across many platforms and is what we generally use.

Member

hadley commented May 25, 2022 •

edited

Loading

It seems like https://github.com/r-lib/lintr/blob/lint-error/R/methods.R#L68-L82 assumes in_ci() will return TRUE on GHA.

...

Oh but there's a separate branch specifically for GHA: https://github.com/r-lib/lintr/blob/lint-error/R/methods.R#L65-L67

MichaelChirico added the automation 🤖 label

Collaborator

IndrajeetPatil commented Apr 2, 2024

This is no longer relevant (cf. #2446).

IndrajeetPatil closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment