Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: User creation #62

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Refactor: User creation #62

merged 2 commits into from
Sep 19, 2023

Conversation

JuaniRodriguez
Copy link
Contributor

Summary

When a student submitted an assignment and the user did not exist yet, the 'username' field was stored as 'NULL' in the database. This PR modifies the user creation process by adding the 'username' with 'email' value.

Evidence

image

@github-actions
Copy link

LCOV of commit d6db406 during CI workflow #60

Summary coverage rate:
  lines......: 95.6% (539 of 564 lines)
  functions..: 98.6% (72 of 73 functions)
  branches...: 86.0% (153 of 178 branches)

Files changed coverage rate:
                                                                           |Lines       |Functions  |Branches    
  Filename                                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================================
  src/commands/tarea/uploadTarea.ts                                        | 100%     23| 100%     2| 100%      6

@JuaniRodriguez JuaniRodriguez merged commit aaa4c0c into main Sep 19, 2023
2 checks passed
@JuaniRodriguez JuaniRodriguez deleted the refactor/create-user branch September 19, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants