-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
included new type_uuid #64
Conversation
Automatic reply from Jenkins: Can I test this? |
@stdweird already told me that we must change the old comments code to the new documentation format, I will do that (that's the reason why I don't like to modify old code... 😄) |
😀 Hey, it's just an opportunity to make things better right...? |
|
||
VERSION: 3.2.7, 21/08/09 22:22 | ||
AUTHOR: Martin Bock | ||
MAINTAINER: Marco Emilio Poleggi <[email protected]>, German Cancio <[email protected]>, Michel Jouvin <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be in @maintainer{}
blocks?
I'm not sure, just looking at the examples in https://quattor-pan.readthedocs.org/en/pan-10.2/pan-book/pan-book.html#annotations...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, I was just wondering about that as well.. I will include a @maintainer
block for each one
email = [email protected] | ||
} | ||
@documentation{ | ||
This is 'namespaces/standard/pan/types.tpl', a pan-templates's file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove whole block till the actual documentation (Data type ...
). This is irrelevant, ancient and redundant
@alvarosimon no need to repeat the function or type is is annotated; that is covered by the tools that generate the docs from the annotations. |
@stdweird ok I will remove the unnecessary documentation blocks |
Much better. |
UUID type is used by different Quattor components. It makes sense to include it into pan/types