ncm-opennebula: Open vSwitch support and VNET pools #466

alvarosimon · 2015-04-03T13:11:13Z

This PR includes several bug fixes and new features:

ncm-opennebula: Add VNET Address Ranges support #463 Add VNET Address Ranges support.
ncm-opennebula: Include Open vSwitch support #455 Include Open vSwitch support .
ncm-opennebula: set syslog instead log files if it is required #454 Set syslog instead log files if it is required.
ncm-opennebula: include oned.conf unittest #401 Include oned.conf unittest.

"type" : string = 'FIXED' VNET option is deprecated since OpenNebula 4.8.x and it was removed (now this option is included within AR address range pools ). This is a backwards incompatible change so OpenNebula component requires ONE version 4.8.x or above.

NOTE: This PR requires a new pan/type type_uuid Included in quattor/template-library-core#64

hpcugentbot · 2015-04-03T13:20:48Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/611/
Test PASSed.

stdweird · 2015-04-03T14:56:17Z

ncm-opennebula/src/main/pan/components/opennebula/schema.pan

@@ -133,6 +134,19 @@ type opennebula_ceph_datastore = {
    "rbd_format"                ? long(1..2)
 };

+@{ 


all the annotations must be fixed according to http://quattor-pan.readthedocs.org/en/latest/pan-book/pan-book.html#annotations. in particular, the annotation for a type has to start with @documentation{, should be simple search and replace

stdweird · 2015-04-03T15:02:14Z

@alvarosimon minor remarks, i don't mind the backwards incompatible stuff if this goes in 15.4
@jrha thoughts?

alvarosimon · 2015-04-03T15:16:49Z

@stdweird @jrha about the backwards incompatible stuff like:
"type" : string = 'FIXED'
yes this is deprecated since ONE 4.8.0 and we don't support versions below this, so it's safe to remove this. In fact we are still including this value in our templates but it is ignored by the new opennebula versions.

hpcugentbot · 2015-04-07T07:57:31Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/613/
Test PASSed.

hpcugentbot · 2015-04-07T08:42:04Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/614/
Test PASSed.

stdweird · 2015-04-08T06:38:26Z

@alvarosimon LGTM, simply change the title of the PR and give some feedback wrt testing

alvarosimon · 2015-04-08T07:44:27Z

@stdweird the PR name was changed, I will test this with the current perl-Net-OpenNebula version during the next days...

hpcugentbot · 2015-04-08T07:58:45Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/617/
Test FAILed.

stdweird · 2015-04-08T09:01:22Z

test this please

hpcugentbot · 2015-04-08T09:14:37Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/620/
Test PASSed.

alvarosimon · 2015-04-16T11:58:44Z

Tested in altaria, no issues found. The vnet pool creation also works with the current perl-Net-OpenNebula version, and that's great 😄

jrha · 2015-04-17T10:36:46Z

ncm-opennebula/src/test/resources/one.pan

@@ -75,4 +92,6 @@ prefix "/software/components/opennebula";
 );

 "ssh_multiplex" = true;
+"host_hyp" = "kvm";
+"host_ovs" = true;
 "tm_system_ds" = "ssh";


Could you add the missing newline at the end of this file please.

jrha · 2015-04-17T10:37:52Z

Cool, I'm happy with this (newline excepted). Any other comments before merge?

hpcugentbot · 2015-04-17T11:55:11Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/628/
Test PASSed.

alvarosimon · 2015-04-17T11:55:44Z

@jrha done! remarks addressed

jrha · 2015-04-17T12:34:28Z

ncm-opennebula/src/main/resources/tests/profiles/vnet_ovsbr0.pan

+"network_mask" = "255.255.0.0";
+"vlan" = true;
+"vlan_id" = 0;
+"ar" = nlist(


jrha · 2015-04-17T12:36:52Z

You could consider replacing all nlist with dict.

…lkit

hpcugentbot · 2015-04-20T09:10:06Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/630/
Test PASSed.

hpcugentbot · 2015-04-20T13:19:42Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/631/
Test PASSed.

hpcugentbot · 2015-04-20T14:09:43Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/632/
Test PASSed.

hpcugentbot · 2015-04-21T07:21:15Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/638/
Test FAILed.

alvarosimon · 2015-04-21T07:21:22Z

@jrha remarks addressed, I think that now is ok, let me know if we need to change something else. About the new type_uuid I have created a new PR in template-library-core repo.

jrha · 2015-04-21T09:58:16Z

Awesome thanks! The tests will fail here until quattor/template-library-core#64 is merged.

jrha · 2015-04-27T09:30:19Z

retest this please

hpcugentbot · 2015-04-27T09:39:44Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/639/
Test FAILed.

jrha · 2015-04-27T10:34:16Z

@stdweird, does Jenkins need to update template-library-core?

stdweird · 2015-04-27T12:22:21Z

@jrha, yes, i'll automate that once it has unittests of its own

stdweird · 2015-04-27T12:22:29Z

test this please

hpcugentbot · 2015-04-27T12:37:08Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/641/
Test PASSed.

jrha · 2015-04-27T12:38:25Z

Awesome.

ncm-opennebula: Open vSwitch support and VNET pools

alvarosimon added 6 commits April 2, 2015 15:46

fix schema and tests to use OVS bridges

6c71e03

included Open vSwitch support

6aa691f

set vnm_mad value

d0b79ac

Included vnet AR option

e68ef2c

rpc data updated with new examples

8592936

Included syslog example

b62de60

stdweird reviewed Apr 3, 2015
View reviewed changes

stdweird added this to the 15.4 milestone Apr 3, 2015

fix pan annotations

fcc5ec6

rpcdata ovs update

0df14c4

alvarosimon changed the title ~~Opennebula Open vSwitch support and VNET pools~~ ncm-opennebula: Open vSwitch support and VNET pools Apr 8, 2015

jrha reviewed Apr 17, 2015
View reviewed changes

add missing newline

b315433

jrha reviewed Apr 17, 2015
View reviewed changes

fix pair.key FILTER upper method to work with older perl-Template-Too…

a8bce71

…lkit

alvarosimon mentioned this pull request Apr 20, 2015

upper method in tt files gives an empty string quattor/CAF#88

Closed

fix replaced nlist by dict

f68d247

fix replaced macaddr by pan/type type_hwaddr

c9b86cc

Replaced uuid by pan/type type_uuid

7254795

jrha added a commit that referenced this pull request Apr 27, 2015

Merge pull request #466 from alvarosimon/opennebula_ovs

3145765

ncm-opennebula: Open vSwitch support and VNET pools

jrha merged commit 3145765 into quattor:master Apr 27, 2015

This was referenced Apr 29, 2015

ncm-opennebula: Add VNET Address Ranges support #463

Closed

ncm-opennebula: Include Open vSwitch support #455

Closed

ncm-opennebula: set syslog instead log files if it is required #454

Closed

ncm-opennebula: include oned.conf unittest #401

Closed

jrha added the backwards incompatible label May 13, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ncm-opennebula: Open vSwitch support and VNET pools #466

ncm-opennebula: Open vSwitch support and VNET pools #466

alvarosimon commented Apr 3, 2015

hpcugentbot commented Apr 3, 2015

stdweird Apr 3, 2015

stdweird commented Apr 3, 2015

alvarosimon commented Apr 3, 2015

hpcugentbot commented Apr 7, 2015

hpcugentbot commented Apr 7, 2015

stdweird commented Apr 8, 2015

alvarosimon commented Apr 8, 2015

hpcugentbot commented Apr 8, 2015

stdweird commented Apr 8, 2015

hpcugentbot commented Apr 8, 2015

alvarosimon commented Apr 16, 2015

jrha Apr 17, 2015

jrha commented Apr 17, 2015

hpcugentbot commented Apr 17, 2015

alvarosimon commented Apr 17, 2015

jrha Apr 17, 2015

jrha commented Apr 17, 2015

hpcugentbot commented Apr 20, 2015

hpcugentbot commented Apr 20, 2015

hpcugentbot commented Apr 20, 2015

hpcugentbot commented Apr 21, 2015

alvarosimon commented Apr 21, 2015

jrha commented Apr 21, 2015

jrha commented Apr 27, 2015

hpcugentbot commented Apr 27, 2015

jrha commented Apr 27, 2015

stdweird commented Apr 27, 2015

stdweird commented Apr 27, 2015

hpcugentbot commented Apr 27, 2015

jrha commented Apr 27, 2015

ncm-opennebula: Open vSwitch support and VNET pools #466

ncm-opennebula: Open vSwitch support and VNET pools #466

Conversation

alvarosimon commented Apr 3, 2015

hpcugentbot commented Apr 3, 2015

stdweird Apr 3, 2015

Choose a reason for hiding this comment

stdweird commented Apr 3, 2015

alvarosimon commented Apr 3, 2015

hpcugentbot commented Apr 7, 2015

hpcugentbot commented Apr 7, 2015

stdweird commented Apr 8, 2015

alvarosimon commented Apr 8, 2015

hpcugentbot commented Apr 8, 2015

stdweird commented Apr 8, 2015

hpcugentbot commented Apr 8, 2015

alvarosimon commented Apr 16, 2015

jrha Apr 17, 2015

Choose a reason for hiding this comment

jrha commented Apr 17, 2015

hpcugentbot commented Apr 17, 2015

alvarosimon commented Apr 17, 2015

jrha Apr 17, 2015

Choose a reason for hiding this comment

jrha commented Apr 17, 2015

hpcugentbot commented Apr 20, 2015

hpcugentbot commented Apr 20, 2015

hpcugentbot commented Apr 20, 2015

hpcugentbot commented Apr 21, 2015

alvarosimon commented Apr 21, 2015

jrha commented Apr 21, 2015

jrha commented Apr 27, 2015

hpcugentbot commented Apr 27, 2015

jrha commented Apr 27, 2015

stdweird commented Apr 27, 2015

stdweird commented Apr 27, 2015

hpcugentbot commented Apr 27, 2015

jrha commented Apr 27, 2015